Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve issue url "[ 'http://localhost:8000' ]" is responding with HTTP status code NaN #3386

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Solve issue url "[ 'http://localhost:8000' ]" is responding with HTTP status code NaN #3386

merged 2 commits into from
Feb 14, 2023

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Feb 13, 2023

This PR updates

"start-server-and-test": "^1.15.2"

to 1.15.4.

Verification

Local

Execute

npm run open

and check that the logs show "HTTP status code 200" not "HTTP status code NaN" in the excerpt below:

> start-server-and-test start-server http://localhost:8000 cypress:open

1: starting server using command "npm run start-server"
and when url "[ 'http://localhost:8000' ]" is responding with HTTP status code 200
running tests using command "npm run cypress:open"

GitHub action

Similarly to the above, examine the action log files in:

https://github.com/corona-warn-app/cwa-website/actions/workflows/build-and-test.yml

for the job test. It should show "HTTP status code 200".


Internal Tracking ID: EXPOSUREAPP-14775

@MikeMcC399 MikeMcC399 marked this pull request as ready for review February 13, 2023 19:06
@MikeMcC399 MikeMcC399 requested a review from a team February 13, 2023 19:06
@MikeMcC399
Copy link
Contributor Author

@MikeMcC399 MikeMcC399 mentioned this pull request Feb 13, 2023
removes incorrect NaN display in logs
@dsarkar
Copy link
Member

dsarkar commented Feb 14, 2023

Good morning @MikeMcC399! Thanks for providing a PR, we will review it soon.

Copy link
Member

@larswmh larswmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @MikeMcC399!

@larswmh larswmh merged commit 46024ed into corona-warn-app:master Feb 14, 2023
@MikeMcC399 MikeMcC399 deleted the fix/start-server-NaN branch February 14, 2023 08:36
@MikeMcC399
Copy link
Contributor Author

Good morning @dsarkar and @larswmh !

I managed to get the package owner to fix start-server-and-test yesterday. Thanks for merging the update!

@larswmh larswmh mentioned this pull request Feb 14, 2023
21 tasks
Ein-Tim pushed a commit to Ein-Tim/cwa-website that referenced this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants