Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make faq test less senstive for statistics entry #3153

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Make faq test less senstive for statistics entry #3153

merged 1 commit into from
Oct 19, 2022

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Oct 19, 2022

This PR changes the test data for faq.js to make it less sensitive to the exact text in https://www.coronawarn.app/en/faq/results/#further_details.

Submitting first as draft until Cypress tests completed.

Internal Tracking ID: EXPOSUREAPP-14167

@dsarkar dsarkar self-assigned this Oct 19, 2022
@brianebeling brianebeling marked this pull request as ready for review October 19, 2022 12:35
@brianebeling brianebeling requested a review from a team October 19, 2022 12:35
@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Oct 19, 2022

Successfully tested on master branch and on in-app-statistics using npm test.

From my point of view it is now ready for review.

@brianebeling
Copy link
Member

Hey @MikeMcC399

I tested it successfully on master and with trivial changes to the previously affected text.
Approved, thanks a lot.

@brianebeling brianebeling self-requested a review October 19, 2022 14:10
@dsarkar
Copy link
Member

dsarkar commented Oct 19, 2022

@MikeMcC399 Thanks for the fix.

@dsarkar dsarkar merged commit 26d1651 into corona-warn-app:master Oct 19, 2022
@MikeMcC399 MikeMcC399 deleted the fix/faq-test-statistics branch October 19, 2022 14:14
@larswmh larswmh mentioned this pull request Nov 15, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants