This repository has been archived by the owner on May 16, 2023. It is now read-only.
feat: Override "alex" linting on CODE_OF_CONDUCT.md #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code of conduct file. Signed-off-by: Johannes Amorosa <johannes.amorosa@endocode.com>
dreh23
requested review from
lukasmasuch,
raethlein,
SebastianWolf-SAP and
tkowark
as code owners
|
@dreh23 What exactly is the point of this PR? Would be good if you could explain a little more. |
|
Sure. #215 introduced a linter pipeline. One of the linter's utilizes https://github.com/get-alex/alex. Alex has an override functionality. I do not see the point to lint the Code of Conduct file, because of course here we define explicit wording - so linting would not make any sense. |
dreh23
changed the title
dreh23
changed the title
|
@dreh23 Thanks now it makes sense! |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code of conduct file.
Signed-off-by: Johannes Amorosa johannes.amorosa@endocode.com