Clear measurement tools #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it make sense to have some sort of clear all functionality that loops over all tools? |
|
Yes it would be useful to have that function. This PR is a good idea but it would be better to add a clearToolData function to the toolStateManager, rather than to each individual tool, as is done here. The imageId-specific tool state manager (https://github.com/chafey/cornerstoneTools/blob/master/src/stateManagement/imageIdSpecificStateManager.js#L46) should also be able to clear data (along with adding and getting data). This would solve allow you to clear all data, at least for a single image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a simple feature to clean up measurement tools like length, probe, etc.