Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added inverted scroll direction for StackScrollTool #1535

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

christianmol
Copy link

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Added an option for inverting the scroll direction of the StackScrollTool

  • What is the current behavior? (You can also link to an open issue here)
    StackScrollTool can only scroll in one direction.

  • What is the new behavior (if this is a feature change)?
    By setting the invert option to true, the tool now scrolls the oposite way, like what is possible with the StackScrollWheelTool

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:

Christian Mol added 2 commits March 15, 2023 11:39
…he opposite direction.

Allows the StackScrollTool to be inverted in scroll direction. If used in combination with the
scroll wheel tool that already has an invert option, this tool would not follow the same direction,
resulting in incoherent behaviour.
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #1535 (37affa2) into master (925a3dd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1535   +/-   ##
=======================================
  Coverage   21.70%   21.71%           
=======================================
  Files         287      287           
  Lines       10137    10138    +1     
  Branches     2081     2082    +1     
=======================================
+ Hits         2200     2201    +1     
  Misses       6750     6750           
  Partials     1187     1187           
Impacted Files Coverage Δ
src/tools/StackScrollTool.js 58.82% <100.00%> (+1.24%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant