[cleanup] Bump dependency version and fix new linter errors #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamChou19815
commented
Aug 28, 2019
| @@ -17,12 +17,17 @@ | |||
| "ExportDeclaration": { "minProperties": 10, "multiline": true, "consistent": true } | |||
| } | |||
| ], | |||
| "react/prop-types": "off", | |||
There was a problem hiding this comment.
We already have TS. This is unnecessary
SamChou19815
commented
Aug 28, 2019
| @@ -17,12 +17,17 @@ | |||
| "ExportDeclaration": { "minProperties": 10, "multiline": true, "consistent": true } | |||
| } | |||
| ], | |||
| "react/prop-types": "off", | |||
| "react/jsx-props-no-spreading": "warn", | |||
There was a problem hiding this comment.
I think it may become harmful in the future due to this React commit and we eventually want to fix it. Therefore, I change the level to warning.
SamChou19815
commented
Aug 28, 2019
| "react/jsx-filename-extension": ["error", { "extensions": [".jsx", ".tsx"] }], | ||
| "import/extensions": [".js", ".mjs", ".jsx", ".ts", ".tsx"], | ||
| "react/state-in-constructor": "off", |
There was a problem hiding this comment.
It doesn't work well with
class A extends React.Component {
state = { foo: 'bar' };
}
SamChou19815
commented
Aug 28, 2019
| "react/jsx-filename-extension": ["error", { "extensions": [".jsx", ".tsx"] }], | ||
| "import/extensions": [".js", ".mjs", ".jsx", ".ts", ".tsx"], | ||
| "react/state-in-constructor": "off", | ||
| "import/extensions": "off", |
There was a problem hiding this comment.
It doesn't like json extension
SamChou19815
commented
Aug 28, 2019
| "indent": "off", | ||
| "@typescript-eslint/ban-ts-ignore": "warn", |
There was a problem hiding this comment.
It's better to have warnings so we can fix it eventually.
SamChou19815
commented
Aug 28, 2019
| "@typescript-eslint/indent": ["error", 2], | ||
| "@typescript-eslint/prefer-interface": "off", | ||
| "@typescript-eslint/explicit-function-return-type": ["error", { "allowExpressions": true }], | ||
| "@typescript-eslint/no-angle-bracket-type-assertion": "off", |
There was a problem hiding this comment.
Deprecated in @typescript-eslint v2. Have to keep it and set to off since create-react-app still uses V1. There is a pull request that tries to fix it: facebook/create-react-app#7540
SamChou19815
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside This PR
Bump dependencies to their latest version.
Notes
Since there is a linter version bump, I also fixed all the new linter errors. I suppressed some types of linter errors, and added the rationale in my review comments.
Checklist: