Update ContainerProperties to match k8s PodSpec.

Updated tests to use old and new names. Deprecated old names. Fixes spring-cloud#477
corneil · Sep 20, 2024 · f9c729b · f9c729b
1 parent 324b59c
commit f9c729b
Show file tree

Hide file tree

Showing 5 changed files with 1,755 additions and 1,665 deletions.
diff --git a/.../main/java/org/springframework/cloud/deployer/spi/kubernetes/DefaultContainerFactory.java b/.../main/java/org/springframework/cloud/deployer/spi/kubernetes/DefaultContainerFactory.java
@@ -168,8 +168,13 @@ public Container create(ContainerConfiguration containerConfiguration) {
         envFromSources.addAll(deploymentPropertiesResolver.getSecretRefs(deploymentProperties));
 
         ContainerBuilder container = new ContainerBuilder();
-        container.withName(containerConfiguration.getAppId()).withImage(image).withEnv(envVars).withEnvFrom(envFromSources)
-                .withArgs(appArgs).withVolumeMounts(deploymentPropertiesResolver.getVolumeMounts(deploymentProperties));
+        container.withName(containerConfiguration.getAppId())
+                .withImage(image)
+                .withEnv(envVars)
+                .withEnvFrom(envFromSources)
+                .withArgs(appArgs)
+                .withImagePullPolicy(deploymentPropertiesResolver.getImagePullPolicy(deploymentProperties))
+                .withVolumeMounts(deploymentPropertiesResolver.getVolumeMounts(deploymentProperties));
 
         Set<Integer> ports = new HashSet<>();