Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] add caching for recursive variant checking #2520

Merged
merged 5 commits into from
Jan 25, 2024

Conversation

dpfaffenbauer
Copy link
Member

@dpfaffenbauer dpfaffenbauer commented Jan 25, 2024

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no

fixes #2519

@solverat
Copy link
Contributor

@dpfaffenbauer That looks good to me! 👍 I just stumbled over an existing clear listener:

CoreShop\Bundle\ProductBundle\EventListener\ClearCachedPriceRulesListener:
tags:
- { name: kernel.event_listener, event: coreshop.product_price_rule.post_save, method: clearCachedRules }
- { name: kernel.event_listener, event: coreshop.product_specific_price_rule.post_save, method: clearCachedRules }
- { name: kernel.event_listener, event: coreshop.product_price_rule.post_delete, method: clearCachedRules }
- { name: kernel.event_listener, event: coreshop.product_specific_price_rule.post_delete, method: clearCachedRules }

Don't know if this should be consolidated or at least the new payment rule cleared should be added?

@dpfaffenbauer
Copy link
Member Author

@solverat I am honestly not sure where that tag is set

@dpfaffenbauer
Copy link
Member Author

@solverat just figured it out, that is not used anymore. I'll delete it

@dpfaffenbauer dpfaffenbauer merged commit c408bd7 into coreshop:3.2 Jan 25, 2024
418 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants