Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use asset() helper for logo image #2137

Merged
merged 1 commit into from
Nov 30, 2022
Merged

fix: use asset() helper for logo image #2137

merged 1 commit into from
Nov 30, 2022

Conversation

dkarlovi
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets N/A

Same as #1908 .

@dpfaffenbauer dpfaffenbauer requested a review from a team November 28, 2022 12:48
@dpfaffenbauer dpfaffenbauer added this to the 3.0.3 milestone Nov 28, 2022
dpfaffenbauer
dpfaffenbauer previously approved these changes Nov 28, 2022
View reviewed changes
@dpfaffenbauer
Copy link
Member

please rebase to 3.0 branch

@dkarlovi dkarlovi changed the base branch from master to 3.0 November 28, 2022 14:38
@CLAassistant
Copy link

CLAassistant commented Nov 28, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dkarlovi
Copy link
Contributor Author

Done, should be OK now.

@dpfaffenbauer dpfaffenbauer merged commit 4e5cb6b into coreshop:3.0 Nov 30, 2022
@dpfaffenbauer
Copy link
Member

thanks

@dkarlovi dkarlovi deleted the patch-4 branch November 30, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpfaffenbauer dpfaffenbauer dpfaffenbauer approved these changes

Assignees

@dkarlovi dkarlovi

Labels
bug
Projects
None yet
Milestone
3.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@dkarlovi @dpfaffenbauer @CLAassistant