[VariantBundle] Serializer: Allow $innerObject to be null #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongerig
changed the title
|
why can it be null? |
|
Because one of my color choices is basically a fallback value with no actual color code. All of the values which do not map to an existing color attribute are assigned this "other / unknown" color value. These values are fed by an external API, over which I do not have any control. This way I'm able to categorize those "other" values to this fallback attribute, which would be really flexible IMO. |
|
legit |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the value of
$innerObjectis allowed to be null when serializing a variant group. This prevents throwing an error when rendering the product detail page and thus makes this process more flexible.