[Rule] refactor Rule conditions and actions peristance #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add sorting field - Fixes in Entity Merger with ManyToMany Collections - Add reloading of conditions/actions on save - Force reload Resource on save - Fix orphan removal for conditions and actions
|
Could also solve #1557? |
|
@ramundomario probably |
|
@ramundomario I just tested it with this fix, it works for sending different emails. But I never tested it before the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS A BC BREAK! But I don't see a way around it. This is due to how Symfony Form works with Collections/Arrays. We have to refactor that in order to make it properly work.