[ProductQuantityPriceRules] add interface for QuantityPriceFetcher and QuantityRuleFetcher

src/CoreShop/Component/ProductQuantityPriceRules/Fetcher/QuantityPriceFetcher.php

@@ -19,7 +19,7 @@
 use CoreShop\Component\Registry\ServiceRegistryInterface;
 use CoreShop\Component\ProductQuantityPriceRules\Model\QuantityRangePriceAwareInterface;
 
-class QuantityPriceFetcher
+class QuantityPriceFetcher implements QuantityPriceFetcherInterface
 {
     /**
      * @var ServiceRegistryInterface
@@ -34,17 +34,6 @@ public function __construct(ServiceRegistryInterface $calculatorRegistry)
         $this->calculatorRegistry = $calculatorRegistry;
     }
 
-    /**
-     * @param ProductQuantityPriceRuleInterface $rule
-     * @param QuantityRangePriceAwareInterface  $subject
-     * @param float                             $quantity
-     * @param int                               $originalPrice
-     * @param array                             $context
-     *
-     * @throws NoPriceFoundException
-     *
-     * @return int
-     */
     public function fetchQuantityPrice(
         ProductQuantityPriceRuleInterface $rule,
         QuantityRangePriceAwareInterface $subject,
@@ -60,16 +49,6 @@ public function fetchQuantityPrice(
         return $service->calculateForQuantity($rule, $subject, $quantity, $originalPrice, $context);
     }
 
-    /**
-     * @param QuantityRangeInterface           $range
-     * @param QuantityRangePriceAwareInterface $subject
-     * @param int                              $originalPrice
-     * @param array                            $context
-     *
-     * @throws NoPriceFoundException
-     *
-     * @return int
-     */
     public function fetchRangePrice(
         QuantityRangeInterface $range,
         QuantityRangePriceAwareInterface $subject,

src/CoreShop/Component/ProductQuantityPriceRules/Fetcher/QuantityPriceFetcherInterface.php

@@ -0,0 +1,59 @@
+<?php
+/**
+ * CoreShop.
+ *
+ * This source file is subject to the GNU General Public License version 3 (GPLv3)
+ * For the full copyright and license information, please view the LICENSE.md and gpl-3.0.txt
+ * files that are distributed with this source code.
+ *
+ * @copyright  Copyright (c) 2015-2020 Dominik Pfaffenbauer (https://www.pfaffenbauer.at)
+ * @license    https://www.coreshop.org/license     GNU General Public License version 3 (GPLv3)
+ */
+
+namespace CoreShop\Component\ProductQuantityPriceRules\Fetcher;
+
+use CoreShop\Component\ProductQuantityPriceRules\Calculator\CalculatorInterface;
+use CoreShop\Component\ProductQuantityPriceRules\Exception\NoPriceFoundException;
+use CoreShop\Component\ProductQuantityPriceRules\Model\ProductQuantityPriceRuleInterface;
+use CoreShop\Component\ProductQuantityPriceRules\Model\QuantityRangeInterface;
+use CoreShop\Component\Registry\ServiceRegistryInterface;
+use CoreShop\Component\ProductQuantityPriceRules\Model\QuantityRangePriceAwareInterface;
+
+interface QuantityPriceFetcherInterface
+{
+    /**
+     * @param ProductQuantityPriceRuleInterface $rule
+     * @param QuantityRangePriceAwareInterface  $subject
+     * @param float                             $quantity
+     * @param int                               $originalPrice
+     * @param array                             $context
+     *
+     * @throws NoPriceFoundException
+     *
+     * @return int
+     */
+    public function fetchQuantityPrice(
+        ProductQuantityPriceRuleInterface $rule,
+        QuantityRangePriceAwareInterface $subject,
+        float $quantity,
+        int $originalPrice,
+        array $context
+    );
+
+    /**
+     * @param QuantityRangeInterface           $range
+     * @param QuantityRangePriceAwareInterface $subject
+     * @param int                              $originalPrice
+     * @param array                            $context
+     *
+     * @throws NoPriceFoundException
+     *
+     * @return int
+     */
+    public function fetchRangePrice(
+        QuantityRangeInterface $range,
+        QuantityRangePriceAwareInterface $subject,
+        int $originalPrice,
+        array $context
+    );
+}

src/CoreShop/Component/ProductQuantityPriceRules/Fetcher/QuantityRuleFetcher.php

@@ -17,7 +17,7 @@
 use CoreShop\Component\ProductQuantityPriceRules\Model\QuantityRangePriceAwareInterface;
 use CoreShop\Component\ProductQuantityPriceRules\Rule\Fetcher\ValidRulesFetcherInterface;
 
-class QuantityRuleFetcher
+class QuantityRuleFetcher implements QuantityRuleFetcherInterface
 {
     /**
      * @var ValidRulesFetcherInterface
@@ -32,14 +32,6 @@ public function __construct(ValidRulesFetcherInterface $validRulesFetcher)
         $this->validRulesFetcher = $validRulesFetcher;
     }
 
-    /**
-     * @param QuantityRangePriceAwareInterface $subject
-     * @param array                            $context
-     *
-     * @throws NoRuleFoundException
-     *
-     * @return ProductQuantityPriceRuleInterface
-     */
     public function fetch(QuantityRangePriceAwareInterface $subject, array $context)
     {
         $quantityPriceRules = $this->getQuantityPriceRulesForSubject($subject, $context);
@@ -54,13 +46,7 @@ public function fetch(QuantityRangePriceAwareInterface $subject, array $context)
 
         return $quantityPriceRules[0];
     }
-
-    /**
-     * @param QuantityRangePriceAwareInterface $subject
-     * @param array                            $context
-     *
-     * @return array|ProductQuantityPriceRuleInterface[]
-     */
+
     public function getQuantityPriceRulesForSubject(QuantityRangePriceAwareInterface $subject, array $context)
     {
         /** @var ProductQuantityPriceRuleInterface[] $rules */

src/CoreShop/Component/ProductQuantityPriceRules/Fetcher/QuantityRuleFetcherInterface.php

@@ -0,0 +1,39 @@
+<?php
+/**
+ * CoreShop.
+ *
+ * This source file is subject to the GNU General Public License version 3 (GPLv3)
+ * For the full copyright and license information, please view the LICENSE.md and gpl-3.0.txt
+ * files that are distributed with this source code.
+ *
+ * @copyright  Copyright (c) 2015-2020 Dominik Pfaffenbauer (https://www.pfaffenbauer.at)
+ * @license    https://www.coreshop.org/license     GNU General Public License version 3 (GPLv3)
+ */
+
+namespace CoreShop\Component\ProductQuantityPriceRules\Fetcher;
+
+use CoreShop\Component\ProductQuantityPriceRules\Exception\NoRuleFoundException;
+use CoreShop\Component\ProductQuantityPriceRules\Model\ProductQuantityPriceRuleInterface;
+use CoreShop\Component\ProductQuantityPriceRules\Model\QuantityRangePriceAwareInterface;
+use CoreShop\Component\ProductQuantityPriceRules\Rule\Fetcher\ValidRulesFetcherInterface;
+
+interface QuantityRuleFetcherInterface
+{
+    /**
+     * @param QuantityRangePriceAwareInterface $subject
+     * @param array                            $context
+     *
+     * @throws NoRuleFoundException
+     *
+     * @return ProductQuantityPriceRuleInterface
+     */
+    public function fetch(QuantityRangePriceAwareInterface $subject, array $context);
+
+    /**
+     * @param QuantityRangePriceAwareInterface $subject
+     * @param array                            $context
+     *
+     * @return array|ProductQuantityPriceRuleInterface[]
+     */
+    public function getQuantityPriceRulesForSubject(QuantityRangePriceAwareInterface $subject, array $context);
+}