Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix return empty string if $string is null #1514

Closed
wants to merge 76 commits into from
Closed

fix return empty string if $string is null #1514

wants to merge 76 commits into from

Conversation

albertmueller
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #1498

dpfaffenbauer and others added 30 commits May 19, 2020 08:32
* [OrderCreation] allow to create a new customer within the order-creation process in backend

* [OrderCreation] allow to create a new address on sale creation

* [All] refactor for Cart = Order = Quote. Only separation is a status field

* [All] further refactor cart=order=quote

* re-add migrations

* remove cart and quote
add migration from cart to cart-order

* [Order] refactor backend ordre creation

* [Order] refactor order-creation, order-detail javascript wise

* [All] add typeidentifiers

* [All] further add types

* [All] further add types

* [All] further add types

* [All] further add types

* [All] refactor for Cart = Order = Quote. fix tests after merging type-hints branch

* [Stan] fix stan issues

* [PHPUnit] remove cause it is not up-to-date and superceded by behat

* [Behat] bootstrap

* [Behat] bootstrap

* [3.0] fix type for customer repo

* [Behat] fix tests

* [3.0] bump branch to 3.0

* [3.0] merge and refactor changes from 2.2

* [3.0] strict types and tests

* [3.0] order return types

* [3.0] type fixes

* [3.0] revert forceFind(int) to forceFind(mixed) and fix orderShipment and orderInvoice generation

* [3.0] add translation for sale_type transition

* Merge branch 'master' into 3.0

* [3.0] revert type for findor404 in resource controller

* [3.0] make service-aliases deprecated and change all internal uses of it

* [3.0] bump symfony to 4.3

* remove symfony version from travis installer

* [3.0] remove not needed classes

* remove behat env

* fix phpstan kernel file name

* [stan] fix stan tests

* [stan] fix stan tests

* fix behat test

* add 3.0 changelog

* [3.0] remove php template helpers

* [3.0] add upgrade notes

* [3.0] change base-currency conversion -> base-currency ALWAYS is Store Currency, where as the display currency is the one we need to convert

* [3.0] remove php template helpers - fix missing service alias

* [3.0] change base-currency conversion -> base-currency ALWAYS is Store Currency, where as the display currency is the one we need to convert - fixes

* [3.0] better manage base values

* [3.0] add upgrade info for removal of template engine

* [3.0] add upgrade log

* [3.0] add type-hints upgrade note

* [3.0] change IndexableInterface and pass IndexInterface

* [3.0] move cheapest carrier resolver to Core and inject CartContext there

* [GithubActions] only test symfony 4 for 3.0

* [Panther] start implementing ui-tests

* [Panther] start implementing ui-tests

* [Panther] start implementing ui-tests

* [Panther] start implementing ui-tests

* [Panther] start implementing ui-tests

* [Panther] start implementing ui-tests - use coreshop mink panther fork

* [Panther] start implementing ui-tests - don't start chrome, panther does that

* [3.0] add registration and login tests

* [3.0] add registration validation tests

* [3.0] implement reset ui tests

* [3.0] min require Pimcore 6.6

* [3.0] min require Pimcore 6.6

* [3.0] disable cache buster for CoreShop Frontend Bundle

* [3.0] add change-password tests

* [3.0] add basic customer profile tests

* [3.0] add basic customer profile tests

* [3.0] run behat tests in container

* [3.0] run behat tests in container - revert

* [3.0] use symfony webserver to run test suite

* [3.0] use symfony webserver to run test suite

* [3.0] add customer profile settings tests

* [3.0] add profile change validation tests

* [SecurityValidator] only trigger when Pimcore Frontend request

* [3.0] ui-tests fix test suite

* [3.0] add product page and price tests

* [3.0] fix test suites

* [3.0] create Pimcore admin login test

* [3.0] add cart tests

* [FrontendBundle] remove all get calls, Pimcore properties are private for a while now and therefore twig calls the getter anyway

* [3.0] fix stan tests

* [3.0] fix stan tests

* [3.0] tests: refine behat filters

* [3.0] remove travis badge and add github badge

* [3.0] mark tests not working as WIP until panther is erady

* [3.0] fix test run

* [3.0] add tests for cart with units and quantity price rules

* [3.0] add product view tests for quantity price rule with units

* [3.0] add tests for add-to-cart with quantity price rules and units

* [3.0] add tests for min/max qty to order

* [3.0] add out-of-stock ui tests

* [3.0] add cart-price-rule tests

* [3.0] invalidate voucher rule tests

* [3.0] start implementing the checkout

* [3.0] add prevent empty checkout tests

* [3.0] revise shipping checkout form and step and add test for disabled carrier

* [3.0] add missing function

* [3.0] fix tests

* [3.0] introduce class translations

* still use convertAndFormat for frontend display of converted currencies

* [3.0] get rid of base values and introduced converted Values

* [3.0] remove 2.x migrations and add migrations for 3.x

* [3.0] remove 2.x migrations and add migrations for 3.x

* Update UPGRADE-3.0.x.md

Co-Authored-By: Jacob Dreesen <jacob@hdreesen.de>

* [3.0] update Version

* [3.0] fixes for cart-creation process

* [3.0] adapt order backend detail view

* [3.0] allow custom prices to be set in admin for order creation

* [3.0] add missing function to interface

* Merge branch 'master' into 3.0 - stan

* [3.0] add simple precision test

* [Stan] fix stan issues

* [SEO] deprecate seo-bundle and use dachcom-digital/pimcore-seo instead

* Update README.md

* [SEO] fix stan issues

* [CartCollector] fix issue

* [Currency,Frontend] introduce currency fraction display provider service

* [Currency, Frontend] introduce currency fraction display provider service

* [CoreBundle, FrontendBundle] introduce tax-display service to determine if products should be displayed with or without tax

* [3.0] only suggest usage of dachcom-seo and keep CoreShop/Seo

* [3.0] only suggest usage of dachcom-seo and keep CoreShop/Seo

* [3.0] only suggest usage of dachcom-seo and keep CoreShop/Seo

* [3.0] only suggest usage of dachcom-seo and keep CoreShop/Seo

* [3.0] only suggest usage of dachcom-seo and keep CoreShop/Seo

* [3.0] only suggest usage of dachcom-seo and keep CoreShop/Seo

* [3.0] only suggest usage of dachcom-seo and keep CoreShop/Seo

* [3.0] only suggest usage of dachcom-seo and keep CoreShop/Seo

* [CoreBundle] re-add public services

* New Crowdin translations (#1402)

* New translations admin.en.yml (Italian)

Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
Co-authored-by: cs-silentbob <cs-silentbob@users.noreply.github.com>
…key-transformer-service

[All] remove usage of ItemKeyTransformer Service and use DataObject\Service directly
…ures

[Fixtures] update fixtures version and fix Deprecation message
There is a check if a value is 0 in the condition checker, but 0s are not valid in the given form configuration
roynilsson and others added 28 commits July 21, 2020 12:33
Allow null return value in request resolver find store
# Conflicts:
#	src/CoreShop/Bundle/CoreBundle/Application/Version.php
#	src/CoreShop/Bundle/OrderBundle/Controller/CartCreationController.php
#	src/CoreShop/Bundle/OrderBundle/Controller/OrderCreationController.php
#	src/CoreShop/Bundle/OrderBundle/Resources/public/pimcore/js/sale/detail/blocks/detail.js
#	src/CoreShop/Bundle/ResourceBundle/Resources/public/pimcore/js/resource/item.js
#	src/CoreShop/Component/Core/Cart/Rule/Action/DiscountPercentActionProcessor.php
#	src/CoreShop/Component/Core/Order/Processor/CartShippingProcessor.php
#	src/CoreShop/Component/Core/Order/Processor/CartTaxProcessor.php
#	src/CoreShop/Component/Order/Factory/OrderFactory.php
[Theme] resolve theme only if not in admin
@albertmueller albertmueller deleted the issue/2.2-1498 branch November 3, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants