Merge pull request #1881 from dpfaffenbauer/issues/psalm

[Psalm] fix tests

src/CoreShop/Bundle/CoreBundle/DependencyInjection/Compiler/RegisterIndexProductExtensionPass.php

@@ -33,6 +33,9 @@ public function process(ContainerBuilder $container): void
         if ($container->hasParameter($stackId)) {
             $registry = $container->getDefinition('coreshop.registry.index.extensions');
 
+            /**
+             * @var array $stack
+             */
             $stack = $container->getParameter($stackId);
 
             foreach ($stack as $class) {

src/CoreShop/Bundle/FrontendBundle/DependencyInjection/CompilerPass/RegisterFrontendControllerPass.php

@@ -29,6 +29,9 @@ class RegisterFrontendControllerPass implements CompilerPassInterface
 {
     public function process(ContainerBuilder $container): void
     {
+        /**
+         * @var array $controllers
+         */
         $controllers = $container->getParameter('coreshop.frontend.controllers');
 
         foreach ($controllers as $key => $value) {

src/CoreShop/Bundle/IndexBundle/Controller/IndexController.php

@@ -67,6 +67,9 @@ public function getConfigAction(): Response
             ];
         }
 
+        /**
+         * @var array $fieldTypes
+         */
         $fieldTypes = $this->container->getParameter('coreshop.index.mapping_types');
         $fieldTypesResult = [];
 

src/CoreShop/Bundle/NotificationBundle/Controller/NotificationRuleController.php

@@ -29,7 +29,14 @@ public function getConfigAction(Request $request): Response
         $actions = [];
         $types = [];
 
+        /**
+         * @var array $actionTypes
+         */
         $actionTypes = $this->container->getParameter('coreshop.notification_rule.actions.types');
+
+        /**
+         * @var array $conditionTypes
+         */
         $conditionTypes = $this->container->getParameter('coreshop.notification_rule.conditions.types');
 
         foreach ($actionTypes as $type) {

src/CoreShop/Bundle/OrderBundle/Controller/OrderController.php

@@ -79,6 +79,9 @@ class OrderController extends PimcoreController
 
     public function getStatesAction(Request $request): Response
     {
+        /**
+         * @var array $identifiers
+         */
         $identifiers = $this->container->getParameter('coreshop.state_machines');
         $states = [];
         $transitions = [];

src/CoreShop/Bundle/ProductQuantityPriceRulesBundle/CoreExtension/ProductQuantityPriceRules.php

@@ -274,10 +274,21 @@ public function getDataForEditmode($data, $object = null, $params = [])
         $calculationBehaviourTypes = [];
         $pricingBehaviourTypes = [];
 
-        foreach ($this->getContainer()->getParameter('coreshop.product_quantity_price_rules.calculators') as $type) {
+        /**
+         * @var array $calculators
+         */
+        $calculators = $this->getContainer()->getParameter('coreshop.product_quantity_price_rules.calculators');
+
+        /**
+         * @var array $actions
+         */
+        $actions = $this->getContainer()->getParameter('coreshop.product_quantity_price_rules.actions');
+
+        foreach ($calculators as $type) {
             $calculationBehaviourTypes[] = [$type, 'coreshop_product_quantity_price_rules_calculator_' . strtolower($type)];
         }
-        foreach ($this->getContainer()->getParameter('coreshop.product_quantity_price_rules.actions') as $type) {
+
+        foreach ($actions as $type) {
             $pricingBehaviourTypes[] = [$type, 'coreshop_product_quantity_price_rules_behaviour_' . strtolower($type)];
         }
 

src/CoreShop/Bundle/ResourceBundle/Controller/ResourceSettingsController.php

@@ -45,6 +45,9 @@ public function getConfigAction(): Response
         ];
 
         if ($this->container->hasParameter('coreshop.all.pimcore_classes')) {
+            /**
+             * @var array $classes
+             */
             $classes = $this->container->getParameter('coreshop.all.pimcore_classes');
 
             foreach ($classes as $key => $definition) {
@@ -58,6 +61,9 @@ public function getConfigAction(): Response
                 $config['classMap'][$application][$alias] = $class;
             }
 
+            /**
+             * @var array $stack
+             */
             $stack = $this->container->getParameter('coreshop.all.stack.pimcore_class_names');
 
             foreach ($stack as $key => $impl) {

src/CoreShop/Bundle/ResourceBundle/CoreExtension/CoreShopRelation.php

@@ -50,7 +50,12 @@ protected function getCoreShopPimcoreClasses()
 
     public function getParameterTypeDeclaration(): ?string
     {
-        return '?\\' . \Pimcore::getContainer()->getParameter('coreshop.all.stack')[$this->stack];
+        /**
+         * @var array $stack
+         */
+        $stack = \Pimcore::getContainer()->getParameter('coreshop.all.stack');
+
+        return '?\\' . $stack[$this->stack];
     }
 
     public function getReturnTypeDeclaration(): ?string

src/CoreShop/Bundle/ResourceBundle/CoreExtension/CoreShopRelations.php

@@ -65,12 +65,22 @@ public function getReturnTypeDeclaration(): ?string
 
     public function getPhpdocInputType(): ?string
     {
-        return '?\\' . \Pimcore::getContainer()->getParameter('coreshop.all.stack')[$this->stack] . '[]';
+        /**
+         * @var array $stack
+         */
+        $stack = \Pimcore::getContainer()->getParameter('coreshop.all.stack');
+
+        return '?\\' . $stack[$this->stack] . '[]';
     }
 
     public function getPhpdocReturnType(): ?string
     {
-        return '?\\' . \Pimcore::getContainer()->getParameter('coreshop.all.stack')[$this->stack] . '[]';
+        /**
+         * @var array $stack
+         */
+        $stack = \Pimcore::getContainer()->getParameter('coreshop.all.stack');
+
+        return '?\\' . $stack[$this->stack] . '[]';
     }
 
     public function getClasses()

src/CoreShop/Bundle/ResourceBundle/DependencyInjection/Compiler/RegisterPimcoreResourcesPass.php

@@ -24,6 +24,9 @@ final class RegisterPimcoreResourcesPass implements CompilerPassInterface
     public function process(ContainerBuilder $container): void
     {
         try {
+            /**
+             * @var array $resources
+             */
             $resources = $container->getParameter('coreshop.all.pimcore_classes');
             $registry = $container->findDefinition(RegistryInterface::class);
         } catch (InvalidArgumentException) {

src/CoreShop/Bundle/ResourceBundle/DependencyInjection/Compiler/RegisterResourcesPass.php

@@ -25,6 +25,9 @@ final class RegisterResourcesPass implements CompilerPassInterface
     public function process(ContainerBuilder $container): void
     {
         try {
+            /**
+             * @var array $resources
+             */
             $resources = $container->getParameter('coreshop.resources');
             $registry = $container->findDefinition(RegistryInterface::class);
         } catch (InvalidArgumentException) {

src/CoreShop/Bundle/ResourceBundle/DependencyInjection/Compiler/StackClassesPass.php

@@ -25,7 +25,14 @@ public function process(ContainerBuilder $container): void
             return;
         }
 
+        /**
+         * @var array $classes
+         */
         $classes = $container->getParameter('coreshop.all.pimcore_classes');
+
+        /**
+         * @var array $stack
+         */
         $stack = $container->getParameter('coreshop.all.stack');
 
         $classStack = [];

src/CoreShop/Bundle/ResourceBundle/DependencyInjection/Compiler/StackRepositoryPass.php

@@ -31,9 +31,17 @@ public function process(ContainerBuilder $container): void
             return;
         }
 
+        /**
+         * @var array $stackConfig
+         */
         $stackConfig = $container->getParameter('coreshop.all.stack');
 
-        foreach ($container->getParameter('coreshop.all.stack.fqcns') as $alias => $classes) {
+        /**
+         * @var array $fqcns
+         */
+        $fqcns = $container->getParameter('coreshop.all.stack.fqcns');
+
+        foreach ($fqcns as $alias => $classes) {
             [$applicationName, $name] = explode('.', $alias);
 
             $definition = new Definition(Metadata::class);

src/CoreShop/Bundle/ResourceBundle/DependencyInjection/CoreShopResourceExtension.php

@@ -100,6 +100,9 @@ private function loadPersistence(array $drivers, array $resources, LoaderInterfa
 
     private function loadResources(array $loadedResources, ContainerBuilder $container): void
     {
+        /**
+         * @var array $resources
+         */
         $resources = $container->hasParameter('coreshop.resources') ? $container->getParameter('coreshop.resources') : [];
 
         foreach ($loadedResources as $alias => $resourceConfig) {
@@ -149,6 +152,9 @@ protected function loadPimcoreModels(array $models, ContainerBuilder $container)
             $metadata = Metadata::fromAliasAndConfiguration($alias, $resourceConfig);
 
             foreach (['coreshop.all.pimcore_classes', sprintf('%s.pimcore_classes', $metadata->getApplicationName())] as $parameter) {
+                /**
+                 * @var array $resources
+                 */
                 $resources = $container->hasParameter($parameter) ? $container->getParameter($parameter) : [];
                 $resources[$alias] = $resourceConfig;
 

src/CoreShop/Bundle/ResourceBundle/DependencyInjection/Driver/Pimcore/PimcoreDriver.php

@@ -125,6 +125,9 @@ protected function addPimcoreClass(ContainerBuilder $container, MetadataInterfac
                 $allPaths = [];
 
                 if ($container->hasParameter($parameterName)) {
+                    /**
+                     * @var array $allPaths
+                     */
                     $allPaths = $container->getParameter($parameterName);
                 }
 

src/CoreShop/Bundle/ResourceBundle/DependencyInjection/Extension/AbstractModelExtension.php

@@ -106,6 +106,9 @@ public function registerStack(string $applicationName, array $stack, ContainerBu
         $globalParameterName = 'coreshop.all.stack';
 
         foreach ([$appParameterName, $globalParameterName] as $parameterName) {
+            /**
+             * @var array $stackConfig
+             */
             $stackConfig = $container->hasParameter($parameterName) ? $container->getParameter($parameterName) : [];
 
             foreach ($stack as $key => $interface) {
@@ -156,6 +159,9 @@ protected function registerPimcoreResources($applicationName, $bundleResources,
             }
 
             if ($container->hasParameter($globalParameter)) {
+                /**
+                 * @var array $globalPermissions
+                 */
                 $globalPermissions = $container->getParameter($globalParameter);
             }
 
@@ -187,6 +193,9 @@ public function registerDependantBundles($applicationName, $bundles, ContainerBu
         $globalParameterName = 'coreshop.all.dependant.bundles';
 
         foreach ([$appParameterName, $globalParameterName] as $parameterName) {
+            /**
+             * @var array $bundleConfig
+             */
             $bundleConfig = $container->hasParameter($parameterName) ? $container->getParameter($parameterName) : [];
 
             foreach ($bundles as $bundleName) {

src/CoreShop/Bundle/ResourceBundle/Installer/PimcoreClassInstaller.php

@@ -37,6 +37,9 @@ public function installResources(OutputInterface $output, string $applicationNam
         $parameter = $applicationName ? sprintf('%s.pimcore_classes', $applicationName) : 'coreshop.all.pimcore_classes';
 
         if ($this->kernel->getContainer()->hasParameter($parameter)) {
+            /**
+             * @var array $pimcoreClasses
+             */
             $pimcoreClasses = $this->kernel->getContainer()->getParameter($parameter);
             $fieldCollections = [];
             $bricks = [];

src/CoreShop/Bundle/ResourceBundle/Installer/PimcoreDependantBundleInstaller.php

@@ -34,6 +34,9 @@ public function installResources(OutputInterface $output, string $applicationNam
         ;
 
         if ($this->kernel->getContainer()->hasParameter($parameter)) {
+            /**
+             * @var array $bundlesToInstall
+             */
             $bundlesToInstall = $this->kernel->getContainer()->getParameter($parameter);
 
             $progress = new ProgressBar($output);

src/CoreShop/Bundle/ResourceBundle/Installer/PimcoreDocumentsInstaller.php

@@ -39,6 +39,9 @@ public function installResources(OutputInterface $output, string $applicationNam
         ) : 'coreshop.all.pimcore.admin.install.documents';
 
         if ($this->kernel->getContainer()->hasParameter($parameter)) {
+            /**
+             * @var array $documentFilesToInstall
+             */
             $documentFilesToInstall = $this->kernel->getContainer()->getParameter($parameter);
             $docsToInstall = [];
 

src/CoreShop/Bundle/ResourceBundle/Installer/PimcoreGridConfigInstaller.php

@@ -36,6 +36,9 @@ public function installResources(OutputInterface $output, string $applicationNam
         $parameter = $applicationName ? sprintf('%s.pimcore.admin.install.grid_config', $applicationName) : 'coreshop.all.pimcore.admin.install.grid_config';
 
         if ($this->kernel->getContainer()->hasParameter($parameter)) {
+            /**
+             * @var array $routeFilesToInstall
+             */
             $routeFilesToInstall = $this->kernel->getContainer()->getParameter($parameter);
             $gridConfigsToInstall = [];
 

src/CoreShop/Bundle/ResourceBundle/Installer/PimcoreImageThumbnailsInstaller.php

@@ -33,6 +33,9 @@ public function installResources(OutputInterface $output, string $applicationNam
         $parameter = $applicationName ? sprintf('%s.pimcore.admin.install.image_thumbnails', $applicationName) : 'coreshop.all.pimcore.admin.install.image_thumbnails';
 
         if ($this->kernel->getContainer()->hasParameter($parameter)) {
+            /**
+             * @var array $thumbnailFilesToInstall
+             */
             $thumbnailFilesToInstall = $this->kernel->getContainer()->getParameter($parameter);
             $thumbnailsToInstall = [];
 

src/CoreShop/Bundle/ResourceBundle/Installer/PimcorePermissionInstaller.php

@@ -32,6 +32,9 @@ public function installResources(OutputInterface $output, string $applicationNam
         $parameter = $applicationName ? sprintf('%s.permissions', $applicationName) : 'coreshop.all.permissions';
 
         if ($this->kernel->getContainer()->hasParameter($parameter)) {
+            /**
+             * @var array $permissionGroups
+             */
             $permissionGroups = $this->kernel->getContainer()->getParameter($parameter);
 
             if ($parameter !== 'coreshop.all.permissions') {

src/CoreShop/Bundle/ResourceBundle/Installer/PimcoreRoutesInstaller.php

@@ -33,6 +33,9 @@ public function installResources(OutputInterface $output, string $applicationNam
         $parameter = $applicationName ? sprintf('%s.pimcore.admin.install.routes', $applicationName) : 'coreshop.all.pimcore.admin.install.routes';
 
         if ($this->kernel->getContainer()->hasParameter($parameter)) {
+            /**
+             * @var array $routeFilesToInstall
+             */
             $routeFilesToInstall = $this->kernel->getContainer()->getParameter($parameter);
             $routesToInstall = [];
 

src/CoreShop/Bundle/ResourceBundle/Installer/SqlInstaller.php

@@ -30,6 +30,9 @@ public function installResources(OutputInterface $output, string $applicationNam
         $parameter = $applicationName ? sprintf('%s.pimcore.admin.install.sql', $applicationName) : 'coreshop.all.pimcore.admin.install.sql';
 
         if ($this->kernel->getContainer()->hasParameter($parameter)) {
+            /**
+             * @var array $sqlFilesToExecute
+             */
             $sqlFilesToExecute = $this->kernel->getContainer()->getParameter($parameter);
 
             $progress = new ProgressBar($output);

src/CoreShop/Bundle/ShippingBundle/Controller/CarrierController.php

@@ -21,6 +21,9 @@ class CarrierController extends ResourceController
 {
     public function getConfigAction(): JsonResponse
     {
+        /**
+         * @var array $strategies
+         */
         $strategies = $this->container->getParameter('coreshop.shipping.tax_calculation_strategies');
 
         $convertedStrategies = [];