Add a this_architecture() API, drop nix dependency
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivated by wanting similar code that I was going to add to zincati https://github.com/coreos/zincati/pull/876/files#diff-e21568cc43324fc7c1b72a7f5e92260a33ff8e7a39a9166823db9976be98649bR192 But, mirroring the stream-metadata-go change, let's add the API here. Notably, this lets us also drop the nix dependency, which is valuable because nix keeps bumping semver and it's a nontrivial expensive dependency.
bgilbert
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by wanting similar code that I was going to add to zincati https://github.com/coreos/zincati/pull/876/files#diff-e21568cc43324fc7c1b72a7f5e92260a33ff8e7a39a9166823db9976be98649bR192
But, mirroring the stream-metadata-go change, let's add the API here.
Notably, this lets us also drop the nix dependency, which is valuable because nix keeps bumping semver and it's a nontrivial expensive dependency.