Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: also wrap kernel-install for scriptlets #4950

Merged
merged 2 commits into from
May 8, 2024
Merged

core: also wrap kernel-install for scriptlets #4950

merged 2 commits into from
May 8, 2024

Commits on May 7, 2024

  1. ci/test-container: move URL definitions to the top 

    Prep for next patch.
    @jlebon
    jlebon committed May 7, 2024
    Configuration menu
    Copy the full SHA
    32fd7a0 View commit details
    Browse the repository at this point in the history

  2. core: also wrap kernel-install for scriptlets 

    It's confusing right now how specifically for the kernel, one has to use
this obscure `rpm-ostree cliwrap install-to-root /` command to make it
work. Let's just always enable it: in the client-side layering case, we
don't run kernel scriptlets anyway so the wrapper is unused, and in the
container case, this will allow users to not have to enable cliwrap and
have it leak into their derived image.

I guess in theory, this should also allow us to *stop* ignoring kernel
scriptlets and rely on this instead, though let's leave that for a
separate investigation.

Closes: coreos#4949
    @jlebon
    jlebon committed May 7, 2024
    Configuration menu
    Copy the full SHA
    2a8017c View commit details
    Browse the repository at this point in the history