This repository has been archived by the owner on May 7, 2021. It is now read-only.
Don't create PV AMIs in regions that don't support them #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euank
suggested changes
Feb 7, 2018
platform/api/aws/images.go
Outdated
| @@ -439,6 +454,14 @@ func (a *API) CopyImage(sourceImageID string, regions []string) (map[string]stri | |||
| return nil, err | |||
| } | |||
|
|
|||
| if *image.VirtualizationType == "paravirtual" { | |||
| for _, region := range regions { | |||
| if _, ok := akis[region]; !ok { | |||
There was a problem hiding this comment.
Might as well reuse the RegionSupportsPV helper for readability here.
platform/api/aws/images.go
Outdated
| @@ -439,6 +454,14 @@ func (a *API) CopyImage(sourceImageID string, regions []string) (map[string]stri | |||
| return nil, err | |||
| } | |||
|
|
|||
| if *image.VirtualizationType == "paravirtual" { | |||
There was a problem hiding this comment.
ec2.VirtualizationTypeParavirtual looks like the correct const to use here.
cmd/plume/prerelease.go
Outdated
| destRegions = append(destRegions, region) | ||
| if !pv || aws.RegionSupportsPV(region) { | ||
| destRegions = append(destRegions, region) | ||
| } |
There was a problem hiding this comment.
Perhaps we should have an "else if pv" that logs to indicate each region pv is being skipped for?
We were creating PV images with no AKI ID.
CreatePVImage would previously create an AMI with no AKI ID, and CopyImage would create an image that never exited pending state.
Assume that the BucketRegion for each AWS partition supports PV.
Neither supports PV.
|
Updated. |
euank
approved these changes
Feb 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
eu-west-3andcn-northwest-1, which don't, to plume. Add PV AKI ID forcn-north-1, which does.