Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

kola/tests: add test for MachineID #805

Merged
merged 1 commit into from
Feb 2, 2018
Merged

kola/tests: add test for MachineID #805

merged 1 commit into from
Feb 2, 2018

Conversation

arithx
Copy link
Contributor

@arithx arithx commented Feb 2, 2018

Fixes #568

ajeddeloh
ajeddeloh suggested changes Feb 2, 2018
View reviewed changes
kola/tests/coretest/core.go Outdated
func TestMachineID() error {
id := MachineID()
if id == "" || id == "COREOS_BLANK_MACHINE_ID" {
return fmt.Errorf("machine-id is %s", id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd split this into two if's becuase if it is an empty string this will be a very confusing error.

@arithx
Copy link
Contributor Author

arithx commented Feb 2, 2018

Updated

ajeddeloh
ajeddeloh approved these changes Feb 2, 2018
View reviewed changes
Copy link
Contributor

@ajeddeloh ajeddeloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arithx arithx merged commit 80a3497 into coreos:master Feb 2, 2018
@arithx arithx deleted the machineid branch February 2, 2018 00:35
@bgilbert bgilbert mentioned this pull request Feb 13, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ajeddeloh ajeddeloh ajeddeloh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arithx @ajeddeloh