This repository has been archived by the owner on May 7, 2021. It is now read-only.
Fix coreos.cloudinit.basic and coreos.ignition.v2_1.resource.local on Packet #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid warnings with Ignition >= 0.21.0.
When a cloud-config is provided, we were running coreos-cloudinit twice: once with the config passed to coreos-install and once via oem-cloudinit.service. The two runs were in no particular order and the latter would set the hostname from Packet metadata, potentially overriding any hostname set by the former. When passing a cloud-config to the instance, provide a no-op Ignition config to prevent Ignition from enabling oem-cloudinit.service via default.ign.
Allow tests to check the cluster platform without type assertions so we don't need to make every cluster type public.
On Packet, Ignition runs before the machine's private IP has been configured. On that platform only, contact the TFTP server via its public IP.
dm0-
approved these changes
Jan 29, 2018
arithx
approved these changes
Jan 29, 2018
| @@ -45,14 +45,15 @@ type BaseCluster struct { | |||
|
|
|||
| name string | |||
There was a problem hiding this comment.
Could also switch this from string to platform.Name
There was a problem hiding this comment.
That's the cluster name, not the platform name. The intent of platform.Name is that it should be treated as an enumerated type.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.