Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

cmd/ore/packet: add fields required to instantiate API #783

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

arithx
Copy link
Contributor

@arithx arithx commented Dec 12, 2017

To instantiate a Packet API you're required to provide a working
gcloud JSON key & bucket storage URL. To be able to run ore for
Packet on things like Jenkins where we don't have these in the
pre-configured locations we need to add these options and plumb
them through.

Copy link
Contributor

@dm0- dm0- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the GCS parameters actually used by anything related to cleaning up instances? Could those be made optional so they don't have to be specified when unused?

@arithx
Copy link
Contributor Author

arithx commented Dec 12, 2017

@dm0- Currently we're only cleaning up instances, this is more of a byproduct of the way that the API is instantiated requiring the Google JSON Key & bucket URL.

In the process of updating this PR to use the same variables as are in bin/ore packet create-device and move them up to the top-level.

To instantiate a Packet API you're required to provide a working
gcloud JSON key & bucket storage URL. To be able to run ore for
Packet on things like Jenkins where we don't have these in the
pre-configured locations we need to add these options and plumb
them through.
@arithx
Copy link
Contributor Author

arithx commented Dec 13, 2017

Per the comment about potentially making the parameters optional, I discussed this with @bgilbert OOB and while it's definitely possible we could make them optional the workflow for creating devices/clusters gets a bit more cluttered as they'd need to add an additional call to instantiate the gcloud API & bucket in between the API creation & device creation steps.

Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requiring unused options is unpleasant, but so is separating out GCE credentials, and at some point gc should be cleaning out leaked GS objects as well. I'm willing to live with this for now.

@arithx
Copy link
Contributor Author

arithx commented Feb 1, 2018

Good to merge

@arithx arithx merged commit 7e3eceb into coreos:master Feb 2, 2018
@arithx arithx deleted the packet_gc_fix branch February 2, 2018 00:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants