-
Notifications
You must be signed in to change notification settings - Fork 76
Dockerfile: Simple Dockerfile #1133
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing some of the bigger picture here - this would be a base image?
Can you file e.g. a cosa issue so we hash out some design there? Or does it exist already?
Dockerfile
Outdated
COPY . /tmp/mantle | ||
|
||
RUN yum update -y --nodocs && \ | ||
yum install -y --nodocs make golang gcc && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multi-stage builds are the better way to do this. Also, we should consider using the pre-built OpenShift golang builder images.
cosa refactor -- it denotes that mantle would be used as a layer: https://url.corp.redhat.com/fabdf2c However, another card in the epic notes using this container directly instead. Either way having a container seems like a need.
It exists within Jira as an epic with cards, but not within GitHub to my knowledge. |
d92d502
to
1030dc6
Compare
Signed-off-by: Steve Milner <smilner@redhat.com>
1030dc6
to
abbfc4b
Compare
Seems OK to me, though I think we need a larger discussion about e.g. where this container is built (I would vote for the |
Actually, I'm not sure this is really going to work for the high level goal of making it faster to land testing because we won't have If we want to iterate on tests faster, I think a both easier and bigger win would be extracting the tests from the infrastructure to run the tests. For example, have a Relatedly I want to make it easy for |
That said this likely would work for non QEMU testing...but eh. I think qemu is really really useful. |
cc @darkmuggle