Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

Dockerfile: Simple Dockerfile #1133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ashcrow
Copy link
Member

@ashcrow ashcrow commented Dec 10, 2019

$ podman run --rm localhost/mantle:latest
No command provided: Please choose one of the following:
- ore
- kola
- plume
$ podman run --rm localhost/mantle:latest kola version
mantle/kola version 0.9.0+528-g1030dc62-dirty
$

cc @darkmuggle

Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing some of the bigger picture here - this would be a base image?

Can you file e.g. a cosa issue so we hash out some design there? Or does it exist already?

Dockerfile Outdated
COPY . /tmp/mantle

RUN yum update -y --nodocs && \
yum install -y --nodocs make golang gcc && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multi-stage builds are the better way to do this. Also, we should consider using the pre-built OpenShift golang builder images.

Dockerfile Outdated Show resolved Hide resolved
@ashcrow
Copy link
Member Author

ashcrow commented Dec 10, 2019

I'm missing some of the bigger picture here - this would be a base image?

cosa refactor -- it denotes that mantle would be used as a layer: https://url.corp.redhat.com/fabdf2c

However, another card in the epic notes using this container directly instead. Either way having a container seems like a need.

Can you file e.g. a cosa issue so we hash out some design there? Or does it exist already?

It exists within Jira as an epic with cards, but not within GitHub to my knowledge.

Signed-off-by: Steve Milner <smilner@redhat.com>
@cgwalters
Copy link
Member

Seems OK to me, though I think we need a larger discussion about e.g. where this container is built (I would vote for the coreos/ namespace in api.ci, and if we go that route it also makes it more obvious to use the shared OpenShift golang builder image, etc.) and how it's used (I recall now we discussed having it as a separate container for tests, which makes sense but definitely needs preparatory work in the pipelines).

@cgwalters
Copy link
Member

Actually, I'm not sure this is really going to work for the high level goal of making it faster to land testing because we won't have qemu in the image.

If we want to iterate on tests faster, I think a both easier and bigger win would be extracting the tests from the infrastructure to run the tests. For example, have a kola/ directory in the config repository with shell scripts to run, and teach cosa kola how to iterate over those and load them into kola.

Relatedly I want to make it easy for kola to execute container images with tests.

@cgwalters
Copy link
Member

That said this likely would work for non QEMU testing...but eh. I think qemu is really really useful.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants