Skip to content
This repository has been archived by the owner on Sep 24, 2020. It is now read-only.

Commit

Permalink
filldir[64]: remove WARN_ON_ONCE() for bad directory entries
Browse files Browse the repository at this point in the history
This was always meant to be a temporary thing, just for testing and to
see if it actually ever triggered.

The only thing that reported it was syzbot doing disk image fuzzing, and
then that warning is expected.  So let's just remove it before -rc4,
because the extra sanity testing should probably go to -stable, but we
don't want the warning to do so.

Reported-by: syzbot+3031f712c7ad5dd4d926@syzkaller.appspotmail.com
Fixes: 8a23eb8 ("Make filldir[64]() verify the directory entry filename is valid")
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
torvalds committed Oct 18, 2019
1 parent 6b95cf9 commit b9959c7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fs/readdir.c
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,9 @@ EXPORT_SYMBOL(iterate_dir);
*/
static int verify_dirent_name(const char *name, int len)
{
if (WARN_ON_ONCE(!len))
if (!len)
return -EIO;
if (WARN_ON_ONCE(memchr(name, '/', len)))
if (memchr(name, '/', len))
return -EIO;
return 0;
}
Expand Down

0 comments on commit b9959c7

Please sign in to comment.