Skip to content
This repository has been archived by the owner on Sep 24, 2020. It is now read-only.

Commit

Permalink
padata: Use get_online_cpus/put_online_cpus
Browse files Browse the repository at this point in the history
This patch puts get_online_cpus/put_online_cpus around the places
we modify the padata cpumask to ensure that no cpu goes offline
during this operation.

Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
klassert authored and herbertx committed May 3, 2010
1 parent 7b389b2 commit 6751fb3
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions kernel/padata.c
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,8 @@ int padata_set_cpumask(struct padata_instance *pinst,

mutex_lock(&pinst->lock);

get_online_cpus();

pd = padata_alloc_pd(pinst, cpumask);
if (!pd) {
err = -ENOMEM;
Expand All @@ -452,6 +454,8 @@ int padata_set_cpumask(struct padata_instance *pinst,
padata_replace(pinst, pd);

out:
put_online_cpus();

mutex_unlock(&pinst->lock);

return err;
Expand Down Expand Up @@ -485,8 +489,10 @@ int padata_add_cpu(struct padata_instance *pinst, int cpu)

mutex_lock(&pinst->lock);

get_online_cpus();
cpumask_set_cpu(cpu, pinst->cpumask);
err = __padata_add_cpu(pinst, cpu);
put_online_cpus();

mutex_unlock(&pinst->lock);

Expand Down Expand Up @@ -521,8 +527,10 @@ int padata_remove_cpu(struct padata_instance *pinst, int cpu)

mutex_lock(&pinst->lock);

get_online_cpus();
cpumask_clear_cpu(cpu, pinst->cpumask);
err = __padata_remove_cpu(pinst, cpu);
put_online_cpus();

mutex_unlock(&pinst->lock);

Expand Down Expand Up @@ -626,6 +634,8 @@ struct padata_instance *padata_alloc(const struct cpumask *cpumask,
if (!pinst)
goto err;

get_online_cpus();

pd = padata_alloc_pd(pinst, cpumask);
if (!pd)
goto err_free_inst;
Expand All @@ -647,6 +657,8 @@ struct padata_instance *padata_alloc(const struct cpumask *cpumask,
register_hotcpu_notifier(&pinst->cpu_notifier);
#endif

put_online_cpus();

mutex_init(&pinst->lock);

return pinst;
Expand All @@ -655,6 +667,7 @@ struct padata_instance *padata_alloc(const struct cpumask *cpumask,
padata_free_pd(pd);
err_free_inst:
kfree(pinst);
put_online_cpus();
err:
return NULL;
}
Expand Down

0 comments on commit 6751fb3

Please sign in to comment.