Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oidc: restrict use of context.Background() #364

Merged
merged 1 commit into from
Feb 4, 2023
Merged

Conversation

ericchiang
Copy link
Collaborator

This causes NewRemoteKeySet not to detach the context, and adds a method to create a verifier with an explicit context:

func (*Provider) VerifierContext(context.Context, *Config) *IDTokenVerifier

Fixes #339?

@nic
Copy link

nic commented Feb 1, 2023

LGTM

@ericchiang ericchiang merged commit 2936eb3 into coreos:v3 Feb 4, 2023
@ericchiang ericchiang deleted the ctx branch March 3, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-obvious behavior with long lived oidc.Provider objects: remoteKeySet caches original context
3 participants