design: add in results of python discussion #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgilbert
reviewed
Oct 1, 2018
| shipping python. For `#4` we determined there was not a significant | ||
| number of security issues to make shipping python prohibitive. We can | ||
| achieve the goals for `#1` and `#3` by shipping a *system python* that | ||
| is only accessible to operating system tools and not to end users. |
There was a problem hiding this comment.
It'd be useful to spell out in more detail how this might be implemented.
There was a problem hiding this comment.
I don't disagree, but I think that we haven't fully fleshed out the best options there so it might be a bit premature to add it to the design doc. The first few comments in #32 touched on it a bit, but I think it's worth its own discussion.
Also that discussion may warrant us figuring out if we even need to do it or not (i.e. if we can manage to get python out then no need).
WDYT?
|
rebased on top of latest master |
|
@bgilbert @cgwalters @ajeddeloh can I get a review so we can merge? |
|
LGTM |
cgwalters
approved these changes
Oct 18, 2018
|
🚂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32