manifest: Turn on mutate-os-release

[jlebon]

This allows RPM-OSTree to inject some information in the os-release
about the compose. Notably the VERSION and PRETTY_NAME keys are
updated to reflect the OSTree commit version. A new OSTREE_VERSION key
is also added. This also matches what we had in Fedora Atomic Host.

[lucab]

coreos/fedora-coreos-tracker#154 (comment) has context on some more future usage we want out of this.

[dustymabe]

Before:

NAME=Fedora
VERSION="29 (CoreOS preview)"
ID=fedora
VERSION_ID=29
VERSION_CODENAME=""
PLATFORM_ID="platform:f29"
PRETTY_NAME="Fedora 29 (CoreOS preview)"
ANSI_COLOR="0;34"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:29"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f29/system-administrators-guide/"
SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=29
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=29
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="CoreOS preview"
VARIANT_ID=coreos

After:

NAME=Fedora
VERSION="29.10 (CoreOS preview)"
ID=fedora
VERSION_ID=29
VERSION_CODENAME=""
PLATFORM_ID="platform:f29"
PRETTY_NAME="Fedora 29.10 (CoreOS preview)"
ANSI_COLOR="0;34"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:29"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f29/system-administrators-guide/"
SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=29
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=29
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="CoreOS preview"
VARIANT_ID=coreos
OSTREE_VERSION=29.10

Does this have any effect on what ansible picks up. There was a recent discussion on this cc @samdoran

[jlebon]

Apps ideally shouldn't be using human-targeted strings like PRETTY_NAME and VERSION (unless of course, it's meant to just passthrough for display to humans). Codified keys like VERSION_ID and VARIANT_ID are stable, and those mutate-os-release doesn't touch.

[samdoran]

I don't think this will greatly affect what Ansible gets from this file and ultimately displays to the end user in the form of facts. Thank you for the heads up, though.