tests/upgrade: make more robust, handle cgroups v1 #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've seen nodes get into a stuck state if we made configuration changes to the node in order to workaround the various starting state issues over time. Let's just do a whole instance reboot if we made any configuration changes to the instance to guarantee we don't end up in a situation where the node is waiting forever to upgrade.
In Fedora 41 now apparently cgroups v2 is no longer supported at all: ``` [ 2.070050] Run /init as init process [!!!!!!] Refusing to run under cgroup v1, SY… specified on kernel command line. ``` So when upgrading from older systems that defaulted to cgroups v1 we need to just go ahead and move them over to cgroups v2 so they'll be able to update fully to the latest FCOS releases being built today.
It looks like F41+ systems will simply refuse to boot with a message like: ``` [ 2.070050] Run /init as init process [!!!!!!] Refusing to run under cgroup v1, SY… specified on kernel command line. ```
jlebon
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits. Summary: