Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/kola: New basic test using kola external tests #305

Merged
merged 1 commit into from
Apr 2, 2020
Merged

tests/kola: New basic test using kola external tests #305

merged 1 commit into from
Apr 2, 2020

Conversation

cgwalters
Copy link
Member

Pairs with coreos/coreos-assembler#1252

The motivation here is to get the ball rolling for (where it
makes sense) to have a place to add tests corresponding to changes
in this repository.

@cgwalters cgwalters mentioned this pull request Mar 16, 2020
Merged
@jlebon
Copy link
Member

jlebon commented Mar 19, 2020

I think we can rebase this and hook it to CI now, right?

@cgwalters
Copy link
Member Author

coreos/coreos-ci-lib#16 is needed for that I think?

@jlebon jlebon mentioned this pull request Mar 19, 2020
Merged
@cgwalters
Copy link
Member Author

kola -p qemu-unpriv --cosa-build builds/31.20200323.dev.0/x86_64/meta.json --output-dir tmp/kola run --parallel 8 --exttest /home/jenkins/agent/workspace/fedora-coreos-config_PR-305-SSTLEFOEQFEC2YX4HET64ZVVRA6NFO2WH635C5TPPTS24FJGCQPQ -E src/config

panic: test ext.fedora-coreos-config_PR-305-SSTLEFOEQFEC2YX4HET64ZVVRA6NFO2WH635C5TPPTS24FJGCQPQ already registered

Oh heh of course the "automatic src/config" registration fails when the repo under CI is the config repo.

@cgwalters
Copy link
Member Author

coreos/coreos-ci-lib#18

@cgwalters
Copy link
Member Author

--- PASS: ext.fedora-coreos-config_PR-305-SSTLEFOEQFEC2YX4HET64ZVVRA6NFO2WH635C5TPPTS24FJGCQPQ (28.48s)

🎉

@cgwalters
tests/kola: New basic test using kola external tests
1c8cb8d 
Pairs with coreos/coreos-assembler#1252

The motivation here is to get the ball rolling for (where it
makes sense) to have a place to add tests corresponding to changes
in this repository.
@cgwalters cgwalters mentioned this pull request Mar 24, 2020
Merged
@cgwalters
Copy link
Member Author

OK, restarted that test and back to green!

jlebon
jlebon approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jlebon jlebon merged commit 261be4f into coreos:testing-devel Apr 2, 2020
@jlebon
Copy link
Member

jlebon commented Apr 2, 2020

Re.

--- PASS: ext.fedora-coreos-config_PR-305-SSTLEFOEQFEC2YX4HET64ZVVRA6NFO2WH635C5TPPTS24FJGCQPQ (28.48s)

🎉

Shouldn't this be broken down by test here? So e.g. ext.fedora-coreos-config....basic ?

@cgwalters
Copy link
Member Author

Shouldn't this be broken down by test here? So e.g. ext.fedora-coreos-config....basic ?

That will happen automatically when there are multiple executables in the directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon jlebon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgwalters @jlebon