Skip to content
This repository has been archived by the owner on Sep 4, 2021. It is now read-only.

kube-aws: add option to create a record for externalDNSName automatic… #389

Merged
merged 1 commit into from
Apr 12, 2016

Conversation

cgag
Copy link
Contributor

@cgag cgag commented Apr 8, 2016

…ally

Currently it's on the user to create a record, via Route53 or otherwise,
in order to make the controller IP accessible via externalDNSName. This
commit adds an option to automatically create a Route53 record in a given
hosted zone.

return fmt.Errorf("hostName cannot be blank when createRecordSet is true")
}

r53 := route53.New(c.session)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validateDNSSettings should take the route53 service as a parameter. As is done with validateExistingVPC, an interface should be stubbed out and used to exercise this codepath in the cluster unit tests.

@cgag cgag force-pushed the route53-record-auto branch 2 times, most recently from 14da68a to 6680579 Compare April 11, 2016 19:10
@colhom
Copy link
Contributor

colhom commented Apr 12, 2016

@cgag

  • can you fix the commit message? It overflows the github max length.
  • rebase on top of master, and drop the validate key pair commit

If at all possible in the future, try to separate the commits out on a per/PR basis. If that can't be avoided for whatever reason, make a note of it in the PR that it depends on another PR being merged and possibly rebased under it, if changes are made.

@colhom
Copy link
Contributor

colhom commented Apr 12, 2016

Otherwise, LGTM pending above comments.

Great work cgag.

Currently it's on the user to create a record, via Route53 or otherwise,
in order to make the controller IP accessible via externalDNSName.  This
commit adds an option to automatically create a Route53 record in a given
hosted zone.

Related to: coreos#340, coreos#257
@cgag
Copy link
Contributor Author

cgag commented Apr 12, 2016

My bad. Dropped the key pair commit and fixed the commit message.

@colhom colhom merged commit 4f156d5 into coreos:master Apr 12, 2016
@colhom colhom mentioned this pull request Apr 12, 2016
18 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants