Disable LTO; disable debug symbols in container build #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LTO saves us 1.5 MB (11%) in the release binary with debug symbols disabled. On the other hand it's been an enormous pain. The RHCOS package disables LTO because of problems on s390x. Quay and the Fedora armv7hl builders apparently OOM building 0.12.0 with LTO. And it's not a default option in the first place. Get rid of it.
Wow - does that mean 112MB space savings in FCOS? |
dustymabe
reviewed
Dec 18, 2021
I guess that depends on what our flags are in the RPM spec file there. |
Debug symbols can make it easier to debug problems in production, but our bug reports don't generally take advantage of that, and the symbols increase the binary size from 13 MB to 125 MB.
Nope, in RPM-land we split those symbols out to debuginfo. The container build does not. |
dustymabe
approved these changes
Dec 18, 2021
jlebon
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LTO saves us 1.5 MB (11%) in the release binary with debug symbols disabled. On the other hand it's been an enormous pain. The RHCOS package disables LTO because of problems on s390x. Quay and the Fedora armv7hl builders apparently OOM building 0.12.0 with LTO. And it's not a default option in the first place. Get rid of it.
Meanwhile, our binary size in the container is now 125 MB. Disable debug symbols there to bring it down to 13 MB. Symbols can make it easier to debug problems in production, but our bug reports don't generally take advantage of that, and the space requirement is excessive.