rdcore/rootmap: properly handle linear md devices #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devices that report type "linear" are md devices, even though the type doesn't start with "raid".
This was referenced Nov 30, 2021
|
LGTM, but I do remember we were doing some |
jlebon
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
LGTM!
LGTM, but I do remember we were doing some
dm-linearhacks for LUKS in the past. So I'm not sure if this will conflict with systems still having that layout.
It should be fine. This code is only relevant for first boots, so we don't need to worry about interfering with upgraded systems.
|
dm-linear shows up in the lsblk |
|
Thanks for the feedback, sorry if was overzealous :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devices that report type
linearare md devices, even though the type doesn't start withraid.