Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minato): ensure full SELECT for JoinSelection only #95

Merged
merged 1 commit into from
May 12, 2024

Conversation

Hieuzest
Copy link
Contributor

No description provided.

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.65%. Comparing base (4ad01c0) to head (54cb404).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   98.67%   98.65%   -0.02%     
==========================================
  Files          38       38              
  Lines       10000    10021      +21     
  Branches     2598     2593       -5     
==========================================
+ Hits         9867     9886      +19     
- Misses        133      135       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hieuzest Hieuzest requested a review from shigma May 10, 2024 17:54
@shigma shigma merged commit 2673719 into cordiverse:master May 12, 2024
25 of 26 checks passed
@shigma shigma changed the title fix(core,sql): ensure full SELECT and Field.expr for JoinSelection only fix(minato): ensure full SELECT for JoinSelection only May 12, 2024
@Hieuzest Hieuzest deleted the fix-sql-inline branch May 12, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants