-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(minato): first-class sql json type #43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 98.23% 98.51% +0.27%
==========================================
Files 23 24 +1
Lines 4880 5594 +714
Branches 1206 1416 +210
==========================================
+ Hits 4794 5511 +717
+ Misses 86 83 -3
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Hieuzest
changed the title
feat: runtimeType, $.object, $.array
feat: first level json type and runtimeType support
Oct 28, 2023
Hieuzest
changed the title
feat: first level json type and runtimeType support
feat: first-class json type and runtimeType support
Oct 28, 2023
Hieuzest
changed the title
feat: first-class json type and runtimeType support
feat: first-class sql json type
Oct 29, 2023
PTAL @shigma |
shigma
requested changes
Nov 9, 2023
shigma
reviewed
Nov 9, 2023
Co-authored-by: Shigma <shigma10826@gmail.com>
shigma
changed the title
feat: first-class sql json type
feat(minato): first-class sql json type
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fix: aggr expr cannot be used in project / groupBy extra
use
Selection.groupBy({}, extra)
to perform a full groupingDict<string>
from types of Selection.table to enforce model passingFeatures
$.object
(non-aggr)project multiple fields into single column as json object
$.array
(aggr)aggregate single column table into json array
$.sum
,$.avg
,$.max
,$.min
(non-aggr)perform array ops on json array
$.length
(aggr & non-aggr)the count/length without distinct
$.in
,$.nin
(non-aggr)support $.in(row.value, row.array)
$size
,$el
support json array. thus we may safely deprecate list nowBugfix / Enhancement
Tasks
map/subquery embedednot planned