feat(mysql): create unique index when altering table

cordiverse · Apr 26, 2022 · bc101b2 · bc101b2
1 parent cdd8a4a
commit bc101b2
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 13 deletions.
diff --git a/packages/mysql/package.json b/packages/mysql/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@cosmotype/driver-mysql",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "MySQL Driver for Cosmotype",
   "main": "lib/index.js",
   "typings": "lib/index.d.ts",

diff --git a/packages/mysql/src/index.ts b/packages/mysql/src/index.ts
@@ -86,6 +86,11 @@ interface ColumnInfo {
   DATA_TYPE: string
 }
 
+interface IndexInfo {
+  INDEX_NAME: string
+  COLUMN_NAME: string
+}
+
 interface QueryTask {
   sql: string
   resolve: (value: any) => void
@@ -157,15 +162,15 @@ class MySQLDriver extends Driver {
     this.pool.end()
   }
 
-  private _getColDefs(name: string, columns: ColumnInfo[]) {
+  private _getColDefs(name: string, columns: ColumnInfo[], indexes: IndexInfo[]) {
     const table = this.model(name)
     const { primary, foreign, autoInc } = table
     const fields = { ...table.fields }
     const unique = [...table.unique]
     const create: string[] = []
     const update: string[] = []
 
-    // orm definitions
+    // field definitions
     for (const key in fields) {
       let shouldUpdate = false
       const legacy = columns.find(info => info.COLUMN_NAME === key)
@@ -200,29 +205,39 @@ class MySQLDriver extends Driver {
       }
     }
 
+    // index definitions
     if (!columns.length) {
       create.push(`primary key (${createIndex(primary)})`)
-      for (const key of unique) {
-        create.push(`unique index (${createIndex(key)})`)
-      }
       for (const key in foreign) {
         const [table, key2] = foreign[key]
         create.push(`foreign key (${backtick(key)}) references ${escapeId(table)} (${backtick(key2)})`)
       }
     }
+    for (const key of unique) {
+      const name = makeArray(key).join('_')
+      const legacy = indexes.find(info => info.INDEX_NAME === name)
+      if (!legacy) create.push(`unique index (${createIndex(key)})`)
+    }
 
     return [create, update]
   }
 
   /** synchronize table schema */
   async prepare(name: string) {
-    const columns = await this.queue<ColumnInfo[]>(`
-      SELECT COLUMN_NAME, IS_NULLABLE, DATA_TYPE
-      FROM information_schema.columns
-      WHERE TABLE_SCHEMA = ? && TABLE_NAME = ?
-    `, [this.config.database, name])
-
-    const [create, update] = this._getColDefs(name, columns)
+    const [columns, indexes] = await Promise.all([
+      this.queue<ColumnInfo[]>(`
+        SELECT COLUMN_NAME, IS_NULLABLE, DATA_TYPE
+        FROM information_schema.columns
+        WHERE TABLE_SCHEMA = ? && TABLE_NAME = ?
+      `, [this.config.database, name]),
+      this.queue<IndexInfo[]>(`
+        SELECT COLUMN_NAME, INDEX_NAME
+        FROM information_schema.statistics
+        WHERE TABLE_SCHEMA = ? && TABLE_NAME = ?
+      `, [this.config.database, name]),
+    ])
+
+    const [create, update] = this._getColDefs(name, columns, indexes)
     if (!columns.length) {
       logger.info('auto creating table %c', name)
       return this.queue(`CREATE TABLE ?? (${create.join(',')}) COLLATE = ?`, [name, this.config.charset])