fix(hmr): emit reload event on success

cordiverse · Apr 30, 2024 · 8fa2175 · 8fa2175
1 parent db9530a
commit 8fa2175
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/hmr/package.json b/packages/hmr/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@cordisjs/plugin-hmr",
   "description": "Hot Module Replacement Plugin for Cordis",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "type": "module",
   "main": "lib/index.js",
   "typings": "lib/index.d.ts",

diff --git a/packages/hmr/src/index.ts b/packages/hmr/src/index.ts
@@ -287,9 +287,6 @@ class Watcher extends Service {
       return rollback()
     }
 
-    // emit reload event before replacing loader cache
-    this.ctx.emit('hmr/reload', reloads)
-
     const reload = (plugin: any, children: ForkScope[]) => {
       for (const oldFork of children) {
         const fork = oldFork.parent.plugin(plugin, oldFork.config)
@@ -332,6 +329,9 @@ class Watcher extends Service {
       return
     }
 
+    // emit reload event on success
+    this.ctx.emit('hmr/reload', reloads)
+
     // reset stashed files
     this.stashed = new Set()
   }