-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf: Improve Performance, reduce heap allocations #1202
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1202 +/- ##
==========================================
+ Coverage 82.72% 83.48% +0.76%
==========================================
Files 162 166 +4
Lines 9080 9621 +541
==========================================
+ Hits 7511 8032 +521
- Misses 1319 1338 +19
- Partials 250 251 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
also please post the results of the benchmarks |
This is after using the slice reuse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for @jcchavezs final approval, but LGTM, thanks!
Posting some more before/after benchmarks
Before:
BenchmarkCRSSimplePOST-10 872 1312620 ns/op 317136 B/op 6415 allocs/op
BenchmarkCRSLargePOST-10 12 97123340 ns/op 1694983 B/op 6646 allocs/op
After:
BenchmarkCRSSimplePOST-10 865 1331177 ns/op 316196 B/op 6374 allocs/op
BenchmarkCRSLargePOST-10 12 99717045 ns/op 1492402 B/op 6553 allocs/op
lgtm |
Thanks @soujanyanmbri ! |
Make sure that you've checked the boxes below before you submit PR:
Thanks for your contribution ❤️
Before:
After: