docs: SecAuditLogDir, removes mention of SecAuditLogStorageDir #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M4tteoP
commented
Oct 5, 2024
| @@ -611,8 +611,6 @@ func directiveSecCollectionTimeout(options *DirectiveOptions) error { | |||
| // or the concurrent logging index file (concurrent logging format). | |||
| // Syntax: SecAuditLog [ABSOLUTE_PATH_TO_LOG_FILE] | |||
| // --- | |||
| // When used in combination with mlogc (only possible with concurrent logging), this | |||
There was a problem hiding this comment.
I'm missing the context here, is mlogc something that can be used with Coraza? All the information I found over the web makes me think that it is a leftover and mlogc is very related to Modsec.
There was a problem hiding this comment.
You are right. Mlogc doesn't work, but the JSON logging is way more powerful
jcchavezs
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address https://owasp.slack.com/archives/C02BXH135AT/p1727977719979589.
Users relying on the documentation website are still facing misleading content related to ModSec. As far as I understood,
SecAuditLogStorageDirdoes not exist in Coraza, in favor ofSecAuditLogDir. This PR:SecAuditLogDirin order to make it appear on the website.SecAuditLogStorageDir.Was there a specific reason to omit
SecAuditLogDirfrom the doc, or we just missed it?We can still implement
SecAuditLogStorageDiras an alias if we feel it is needed.