fix: broken TestHardcodedIncludeDirectiveDDOS2 on windows #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzipi
approved these changes
Aug 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1136 +/- ##
==========================================
+ Coverage 82.72% 83.91% +1.19%
==========================================
Files 162 166 +4
Lines 9080 7891 -1189
==========================================
- Hits 7511 6622 -889
+ Misses 1319 1019 -300
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jptosso
reviewed
Aug 26, 2024
internal/seclang/parser_test.go
Outdated
| @@ -169,6 +169,7 @@ func TestHardcodedIncludeDirectiveDDOS2(t *testing.T) { | |||
| if err != nil { | |||
| t.Fatal(err) | |||
| } | |||
| tmpFile2.Close() | |||
There was a problem hiding this comment.
shouldn't we assert errors on tmpFile2.Close()?
jabdr
force-pushed
the
windows-fix-TestHardcodedIncludeDirectiveDDOS2
branch
from
7b25147 to
03cce15
Compare
jcchavezs
requested changes
Aug 28, 2024
jabdr
force-pushed
the
windows-fix-TestHardcodedIncludeDirectiveDDOS2
branch
from
03cce15 to
87ddf45
Compare
|
@jcchavezs I am not sure what you mean. I do not want to touch the existing code in this PR, just fix the missing Close statement (which is also required with os.CreateTemp). |
jcchavezs
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fix for the TestHardcodedIncludeDirectiveDDOS2 on windows.
Windows refuses to delete files as long as the file descriptor is open. Closing the temporary file fixes this issue and go test is able to cleanup the files.