Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - tag missing for aws_kinesis_firehose_delivery_stream resource #197

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

ryantanjunming
Copy link
Contributor

Description

LogDeliveryEnabled = true, Tag was missing for aws_kinesis_firehose_delivery_stream resource

Fixes #194

How Has This Been Tested?

Checklist:

  • I have updated the relevant example in the examples directory for the module.
  • I have updated the relevant test file for the module.
  • This change does not affect module (e.g. it's readme file change)

Copy link
Contributor

@daidokoro daidokoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryantanjunming ryantanjunming merged commit d3300c5 into master Dec 24, 2024
6 checks passed
Copy link

🎉 This PR is included in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firehose-logs: LogDeliveryEnabled tag missing for aws_kinesis_firehose_delivery_stream resource
2 participants