Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deleted private_key in firehose module READMEs #192

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

cazorla19
Copy link
Contributor

@cazorla19 cazorla19 commented Dec 23, 2024

Description

Updated 2 READMEs for firehose-logs and firehose-metrics modules by replacing private_key variable reference by api_key. which was done in 659821d

How Has This Been Tested?

README changes don't need to be tested besides from Markdown Preview check.

Checklist:

  • I have updated the relevant example in the examples directory for the module.
  • I have updated the relevant test file for the module.
  • This change does not affect module (e.g. it's readme file change)

@cazorla19 cazorla19 requested a review from a team as a code owner December 23, 2024 09:20
Copy link
Contributor

@daidokoro daidokoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cazorla19 cazorla19 merged commit bc7e7b1 into master Dec 23, 2024
6 checks passed
Copy link

🎉 This PR is included in version 2.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants