avm: Use #[cfg(unix)]
when running UNIX-only functionality
#3464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After downloading the binary for the specific target, we change file permissions in UNIX to make the file executable:
anchor/avm/src/lib.rs
Lines 275 to 280 in 08110e9
While this technically works (because all non-Windows OS' we release binaries for are UNIX), it would still be better to use
#[cfg(unix)]
to make the intention clearer.Summary of changes
Use
#[cfg(unix)]
when running UNIX-only functionality instead of#[cfg(not(target_os = "windows"))]
.