Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang: Add const of program ID to declare_id! and declare_program! #3019

Merged
merged 7 commits into from
Jun 18, 2024

Conversation

cryptopapi997
Copy link
Contributor

Reopening #3002 because I had accidentally deleted my fork.

Copy link

vercel bot commented Jun 10, 2024

@cryptopapi997 is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@cryptopapi997 cryptopapi997 changed the title lang: Make program ID const instead of static in declare_program! lang: Make program ID const instead of static Jun 10, 2024
@cryptopapi997
Copy link
Contributor Author

thoughts on this @acheroncrypto ?

@acheroncrypto
Copy link
Collaborator

I think it's best to avoid this breaking change, and keep it consistent with solana-program's implementation. We can instead add the const ID as a separate definition.

@cryptopapi997 cryptopapi997 changed the title lang: Make program ID const instead of static lang: Add const of program ID to declare_id! and declare_program! Jun 18, 2024
@cryptopapi997
Copy link
Contributor Author

cryptopapi997 commented Jun 18, 2024

@acheroncrypto Sounds good to me! I've changed it accordingly (except in deprecated_id_to_tokens since this is deprecated and so shouldn't have any new updates anymore unless they're bug fixes)

Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@acheroncrypto acheroncrypto merged commit 3c5483f into coral-xyz:master Jun 18, 2024
2 of 3 checks passed
@cryptopapi997 cryptopapi997 deleted the make-prog-id-const branch June 27, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants