Remove terser for react-native support

[Perronef5]

CHANGES 📲

• Removing rollup-plugin-terser for react-native support.

Reasoning

The anchor-ts client uses rollup to bundle ts code for the browser. In the process of bundling, it passes the code through a minification/uglification plugin called rollup-plugin-terser.

The terser mangles the code in a way that the the variable assigned to the import of @solana/web3.js is reused.

Something similar to this is happening in the final output:

var s = require("@solana/web3.js")

function x() {
  var s, a, b; // ----> redefined s
  ...
  s.TransactionInstruction() // ----> calls method on original s
}

Issues supporting this claim:

#1082
#2054
#1747
https://stackoverflow.com/questions/70652456/solanaweb-3-js-package-typeerror-s-transactioninstruction-is-not-a-constructor/70964609#70964609

[vercel]

@Perronef5 is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

[Henry-E]

Cool, let's run the tests and see what happens!

[Perronef5]

Cool, let's run the tests and see what happens!

Something happened 😅

@Henry-E Can we retry? Seems to be a connection issue

[Henry-E]

• very simple PR
• removes terser() function, going to check why it was there in the first place first before removing
• tests pass

Probably a merge

Before merging though @Perronef5 does this affect the original reason for the terser() function which was part of adding support for next.js #1108 ?

It seems like this might break the minification needed for next.js (though not sure, only gathered that from a cursory google search).

[Perronef5]

• very simple PR
• removes terser() function, going to check why it was there in the first place first before removing
• tests pass

Probably a merge

Before merging though @Perronef5 does this affect the original reason for the terser() function which was part of adding support for next.js #1108 ?

It seems like this might break the minification needed for next.js (though not sure, only gathered that from a cursory google search).

Dang thats a good point. Let me test with next.js

[tlrjs]

Dang thats a good point. Let me test with next.js

Any findings here?

I can't see why Anchor specifically would need to be minified for Next.js. Mango uses Next.js with multiple dependencies that are not minified.

[Henry-E]

Cool, just wanted to get confirmation either way as to whether it would be an issue to remove it. From what you're saying it's sounding less like it should be an issue.

[Perronef5]

Cool, just wanted to get confirmation either way as to whether it would be an issue to remove it. From what you're saying it's sounding less like it should be an issue.

Hey sorry for the late reply. I did get it working with NextJS so we should be good. I see you merged already just wanted to share my findings 👍🏽