Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: also listen to ipv6 #435

Merged
merged 7 commits into from
Apr 16, 2021
Merged

server: also listen to ipv6 #435

merged 7 commits into from
Apr 16, 2021

Conversation

Mic92
Copy link
Contributor

@Mic92 Mic92 commented Apr 16, 2021

The [::] address will listen to both ipv4/ipv6 addresses.

@erogol
Copy link
Member

erogol commented Apr 16, 2021

do you have a point er for that? I checked here but no mention https://flask.palletsprojects.com/en/master/api/#flask.Flask.run

@Mic92
Copy link
Contributor Author

Mic92 commented Apr 16, 2021

"::" is the ipv6 equivalent of ipv4's "0.0.0.0" but also accepts ipv4 addresses. However as I just found out this does not work on Windows... https://stackoverflow.com/questions/57881991/python-flask-dual-stack-on-windows-ipv4-and-ipv6

@mweinelt
Copy link
Contributor

Also only if the linux distro defaults to net.ipv6.bindv6only=0, thought most do.

@Mic92
Copy link
Contributor Author

Mic92 commented Apr 16, 2021

The issue is that people try to connect to localhost, which can also yield ::1 instead of 127.0.0.1 as loopback address in which case connection can fail.

@erogol
Copy link
Member

erogol commented Apr 16, 2021

how about if we just take an host argument and let people decide?

@Mic92
Copy link
Contributor Author

Mic92 commented Apr 16, 2021

That would also make sense but is orthogonal since this is about the default as well.
@SuperSandro just confirmed that :: actually works as intended on windows too.

@erogol
Copy link
Member

erogol commented Apr 16, 2021

Then I merge 👍 !!

@erogol erogol changed the base branch from main to dev April 16, 2021 18:34
@erogol erogol merged commit e31f174 into coqui-ai:dev Apr 16, 2021
@Mic92 Mic92 deleted the ipv6 branch April 16, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants