Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes typo in README.md example code #2478

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Fixes typo in README.md example code #2478

merged 1 commit into from
Apr 5, 2023

Conversation

TCNOco
Copy link
Contributor

@TCNOco TCNOco commented Apr 4, 2023 •
edited
Loading

Running the sample code below results in an error language_id = self.tts_model.language_manager.name_to_id[language_name]. The fix is running the code with the correct language strings, the readme has been updated in this PR to work.

I assume this small typo leads to #2456 and #2458

from

tts.tts_to_file("This is voice cloning.", speaker_wav="my/cloning/audio.wav", language="en", file_path="output.wav")
tts.tts_to_file("C'est le clonage de la voix.", speaker_wav="my/cloning/audio.wav", language="fr", file_path="output.wav")
tts.tts_to_file("Isso é clonagem de voz.", speaker_wav="my/cloning/audio.wav", language="pt", file_path="output.wav")

to

tts.tts_to_file("C'est le clonage de la voix.", speaker_wav="my/cloning/audio.wav", language="fr-fr", file_path="output.wav")
tts.tts_to_file("Isso é clonagem de voz.", speaker_wav="my/cloning/audio.wav", language="pt-br", file_path="output.wav")

@TCNOco
Fix errors in README.md
143cbb2 
Running the sample code below results in an error `language_id = self.tts_model.language_manager.name_to_id[language_name]`.
The fix is running the code with the correct language strings, the readme has been updated in this PR to work.

I assume this small typo leads to coqui-ai#2456 and coqui-ai#2458
@CLAassistant
Copy link

CLAassistant commented Apr 4, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@erogol erogol merged commit ce79160 into coqui-ai:dev Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TCNOco @CLAassistant @erogol