Update ParallelWaveGAN config + Tacotron2 masked loss #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
iamanigeeit
changed the title
erogol
reviewed
May 7, 2022
| @@ -135,6 +134,8 @@ class TacotronConfig(BaseTTSConfig): | |||
| ga_alpha (float): | |||
| Weight for the guided attention loss. If set less than or equal to zero, it disables the corresponding loss | |||
| function. Defaults to 5. | |||
| stopnet_alpha (float): | |||
| Weight for the guided attention loss. Defaults to 100.0 | |||
There was a problem hiding this comment.
This comment incorrectly explains the parameter.
| optimizer (torch.optim.Optimizer): | ||
| Optimizer used for the training. Defaults to `AdamW`. | ||
| optimizer_params (dict): | ||
| Optimizer kwargs. Defaults to `{"betas": [0.8, 0.99], "weight_decay": 0.0}` | ||
| lr_scheduler_gen (torch.optim.Scheduler): | ||
| Learning rate scheduler for the generator. Defaults to `ExponentialLR`. |
There was a problem hiding this comment.
What is the reason for these config changes?
|
Thanks for the PR. As you said, it'd be better to have separate PRs. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing #1187 and #1192
I did not realize that a PR must include all commits in a branch and i should have split into a separate branch for the ParallelWaveGAN config and the Tacotron2 masked loss.