Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hypothesis display from goal list #962

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

rtetley
Copy link
Collaborator

@rtetley rtetley commented Dec 10, 2024

If the goals are displayed as collabsibles, only the first goal has its goal context (hypothesis) displayed.

If the goals are displayed as collabsibles, only the first goal
has its goal context (hypothesis) displayed.
@rtetley
Copy link
Collaborator Author

rtetley commented Dec 10, 2024

Screenshot 2024-12-10 at 14 54 10

Is this readable ? Should I also collapse them by default @ybertot ?

@gares
Copy link
Member

gares commented Dec 10, 2024

This is what we are used to in PG, CoqIDE & co.
About folding, I have no idea what is best. But the user choice should somehow stick.

@TheoWinterhalter
Copy link

Will it be possible to show the hypotheses again if we want? Like maybe by unfolding it?

@ybertot
Copy link

ybertot commented Dec 10, 2024

I thought I had answered one hour ago, but I would like to have the horizontal line displayed.

@ybertot
Copy link

ybertot commented Dec 10, 2024

Well, no, I don't know why I thought it was the habit in proof-general, but it is not. So as far as I am concerned, it is okay, but I think the question of Theo makes sense.

@rtetley
Copy link
Collaborator Author

rtetley commented Dec 10, 2024

Will it be possible to show the hypotheses again if we want? Like maybe by unfolding it?

I suppose I could put a collapsible for the hyps as well. Or add a button, but it will overload the UI a bit. Is it very useful ?

@gares
Copy link
Member

gares commented Dec 10, 2024

Is the tab view displaying the whole context? If so maybe Theo prefers it

@TheoWinterhalter
Copy link

I don't actually care much for the tab display and I think the current proposal is what I would like in most cases so maybe it's not such a necessity.

@ybertot
Copy link

ybertot commented Dec 11, 2024

If it is not too costly, I think a collapsible for the whole context would be good.

@rtetley
Copy link
Collaborator Author

rtetley commented Dec 11, 2024

If it is not too costly, I think a collapsible for the whole context would be good.

I need more context....
Pun aside what do you mean ? Like a nested collapsible for the hyps ? I can think of something

@ybertot
Copy link

ybertot commented Dec 11, 2024

Yes, I meant : make the whole sequence hyps for each goal collapsible.

…text

When a goal is expanded, a secondary action appears next to the collapse/expand
button. This button represented by a closed/open eye allows to show/hide the
goal context (hyps).
@rtetley
Copy link
Collaborator Author

rtetley commented Dec 11, 2024

Screenshot 2024-12-11 at 10 53 42

This is what I came up with. What do you guys think ?

@TheoWinterhalter
Copy link

Sounds great!

@gares
Copy link
Member

gares commented Dec 11, 2024

While you are at it, is it possible to avoid

Goal 3
(3/3) ----

I mean, how many times do we want to tell the user the number of the goal? ;-)

@rtetley
Copy link
Collaborator Author

rtetley commented Dec 11, 2024

While you are at it, is it possible to avoid

Goal 3
(3/3) ----

I mean, how many times do we want to tell the user the number of the goal? ;-)

As many times as possible it turns out x-D #674
Jokes aside, sometimes the context is very large and you don't see the "Goal 3" title after a scroll.

@rtetley rtetley merged commit 050c12d into main Dec 11, 2024
27 of 28 checks passed
@rtetley rtetley deleted the default-goal-display branch December 13, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants