Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hover provider #697

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Improve hover provider #697

merged 5 commits into from
Dec 1, 2023

Conversation

dlesbre
Copy link
Contributor

@dlesbre dlesbre commented Nov 29, 2023

Small PR that changes the hover provider a bit:

  • Add a newline and a horizontal separator between arg and path section in hover
  • Fix hover not appearing at definition sites. Hover now proceeds as follows
    • try getting hover in the context at the start of the current sentence
    • if that fails, try getting hover in the context of the next sentence (newly defined symbols)
    • if that fails, and the next sentence is in proof mode, try using context at next QED (for lemmas and anything defined with tactics).

@rtetley
Copy link
Collaborator

rtetley commented Dec 1, 2023

Hi @dlesbre, Thanks for your contribution :-) I just rebased your branch on main, is it okay if I force push ? I'll then merge !

@dlesbre
Copy link
Contributor Author

dlesbre commented Dec 1, 2023

Sure @rtetley, go ahead !

@rtetley rtetley force-pushed the dlesbre/hover-at-def branch from 86f2a4a to 9b38d37 Compare December 1, 2023 12:04
@rtetley rtetley merged commit defa02b into coq:main Dec 1, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants