Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync Coq opam packages with ocaml repository #1389

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Conversation

RalfJung
Copy link
Contributor

I usually use the packages here as template for the next release, assuming that this is where we keep the latest opam file (as the one in the repo is for experimental dune support). So let's make sure they are in sync.

@RalfJung
Copy link
Contributor Author

RalfJung commented Aug 18, 2020

CI is failing again, but somehow also failed to report that back to GH. EDIT: ah now it showed up.

These are the exact configurations that we use for the opam package for Coq 8.12.0, so I am fairly confident the PR is fine. My guess is that the CI cache is somehow broken. Unfortunately, the log doesn't contain much information about what went wrong:

#=== ERROR while installing coqide.dev ========================================#
Some files in /builds/coq/opam-coq-archive/opam-root-4.05.0-2.0.6-sandbox/4.05.0/.opam-switch/install/coqide.install couldn't be installed:
  - /builds/coq/opam-coq-archive/opam-root-4.05.0-2.0.6-sandbox/4.05.0/.opam-switch/build/coqide.dev/ide/coq_style.xml to /builds/coq/opam-coq-archive/opam-root-4.05.0-2.0.6-sandbox/4.05.0/share
  - /builds/coq/opam-coq-archive/opam-root-4.05.0-2.0.6-sandbox/4.05.0/.opam-switch/build/coqide.dev/ide/coq.png to /builds/coq/opam-coq-archive/opam-root-4.05.0-2.0.6-sandbox/4.05.0/share
  - /builds/coq/opam-coq-archive/opam-root-4.05.0-2.0.6-sandbox/4.05.0/.opam-switch/build/coqide.dev/ide/coq-ssreflect.lang to /builds/coq/opam-coq-archive/opam-root-4.05.0-2.0.6-sandbox/4.05.0/share
  - /builds/coq/opam-coq-archive/opam-root-4.05.0-2.0.6-sandbox/4.05.0/.opam-switch/build/coqide.dev/ide/coq.lang to /builds/coq/opam-coq-archive/opam-root-4.05.0-2.0.6-sandbox/4.05.0/share

@RalfJung
Copy link
Contributor Author

Hm okay it could also be something about Coq master that breaks the old opam? coqide.8.12+beta1 and coqide.8.12.dev work fine.

@RalfJung
Copy link
Contributor Author

Indeed coqide.dev already fails to install without these changes:

#=== ERROR while installing coqide.dev ========================================#
Some files in /home/r/.opam/coq-test/.opam-switch/install/coqide.install couldn't be installed:
  - /home/r/.opam/coq-test/.opam-switch/build/coqide.dev/ide/coq_style.xml to /home/r/.opam/coq-test/share
  - /home/r/.opam/coq-test/.opam-switch/build/coqide.dev/ide/coq.png to /home/r/.opam/coq-test/share
  - /home/r/.opam/coq-test/.opam-switch/build/coqide.dev/ide/coq-ssreflect.lang to /home/r/.opam/coq-test/share
  - /home/r/.opam/coq-test/.opam-switch/build/coqide.dev/ide/coq.lang to /home/r/.opam/coq-test/share

@herbelin
Copy link
Member

Hi @RalfJung,

#=== ERROR while installing coqide.dev ========================================#
Some files in /home/r/.opam/coq-test/.opam-switch/install/coqide.install couldn't be installed:
  - /home/r/.opam/coq-test/.opam-switch/build/coqide.dev/ide/coq_style.xml to /home/r/.opam/coq-test/share
  - /home/r/.opam/coq-test/.opam-switch/build/coqide.dev/ide/coq.png to /home/r/.opam/coq-test/share
  - /home/r/.opam/coq-test/.opam-switch/build/coqide.dev/ide/coq-ssreflect.lang to /home/r/.opam/coq-test/share
  - /home/r/.opam/coq-test/.opam-switch/build/coqide.dev/ide/coq.lang to /home/r/.opam/coq-test/share

I don't know frow where coqide.install comes but the location of these four files in master is now ide/coqide (instead of ide).

@RalfJung
Copy link
Contributor Author

I don't know frow where coqide.install comes

It's in the opam repository.

@RalfJung
Copy link
Contributor Author

@herbelin that works locally, thanks!
Let's see what CI says.

@palmskog palmskog merged commit cb2b73c into coq:master Aug 18, 2020
@RalfJung RalfJung deleted the coq branch August 29, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants