-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split a few easy plugins in a Ltac1-free core and a Ltac1 syntax plugin #19313
Conversation
9260be4
to
87b6354
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want to keep the _core plugins in the same directory you need to handle them in findlib_plugin_fixup
in coq_rules.ml
I think that's why windows is failing
🔴 CI failure at commit 87b6354 without any failure in the test-suite ✔️ Corresponding job for the base commit 16e3f49 succeeded ❔ Ask me to try to extract a minimal test case that can be added to the test-suite 🏃
|
87b6354
to
ef6d8ea
Compare
The coq_lsp dev is missing some pieces of overlay but I'm not quite sure about how to fix the errors. |
@coqbot merge now |
@SkySkimmer: Please take care of the following overlays:
|
We do that for plugins that do not require heavy infrastructural changes, namely:
This is needed for #19032.
Overlays: