Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split a few easy plugins in a Ltac1-free core and a Ltac1 syntax plugin #19313

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

ppedrot
Copy link
Member

@ppedrot ppedrot commented Jul 3, 2024

We do that for plugins that do not require heavy infrastructural changes, namely:

  • cc
  • firstorder
  • nsatz

This is needed for #19032.

Overlays:

@ppedrot ppedrot added kind: cleanup Code removal, deprecation, refactorings, etc. request: full CI Use this label when you want your next push to trigger a full CI. labels Jul 3, 2024
@ppedrot ppedrot added this to the 8.21+rc1 milestone Jul 3, 2024
@ppedrot ppedrot requested review from a team as code owners July 3, 2024 13:31
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Jul 3, 2024
@ppedrot ppedrot added the request: full CI Use this label when you want your next push to trigger a full CI. label Jul 3, 2024
@ppedrot ppedrot force-pushed the ltac1-split-some-plugins branch from 9260be4 to 87b6354 Compare July 3, 2024 13:47
@ppedrot ppedrot requested a review from a team as a code owner July 3, 2024 13:47
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Jul 3, 2024
@SkySkimmer SkySkimmer self-assigned this Jul 3, 2024
Copy link
Contributor

@SkySkimmer SkySkimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want to keep the _core plugins in the same directory you need to handle them in findlib_plugin_fixup in coq_rules.ml

I think that's why windows is failing

Copy link
Contributor

coqbot-app bot commented Jul 3, 2024

🔴 CI failure at commit 87b6354 without any failure in the test-suite

✔️ Corresponding job for the base commit 16e3f49 succeeded

❔ Ask me to try to extract a minimal test case that can be added to the test-suite

🏃 @coqbot ci minimize will minimize the following target: ci-tactician
  • You can also pass me a specific list of targets to minimize as arguments.

ppedrot added a commit to ppedrot/Coq-Equations that referenced this pull request Jul 4, 2024
ppedrot added a commit to ppedrot/coq-lsp that referenced this pull request Jul 4, 2024
ppedrot added a commit to ppedrot/coq-tactician that referenced this pull request Jul 4, 2024
@ppedrot ppedrot added the request: full CI Use this label when you want your next push to trigger a full CI. label Jul 4, 2024
@ppedrot ppedrot force-pushed the ltac1-split-some-plugins branch from 87b6354 to ef6d8ea Compare July 4, 2024 09:28
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Jul 4, 2024
@ppedrot
Copy link
Member Author

ppedrot commented Jul 4, 2024

The coq_lsp dev is missing some pieces of overlay but I'm not quite sure about how to fix the errors.

SkySkimmer pushed a commit to ppedrot/coq-lsp that referenced this pull request Jul 5, 2024
@SkySkimmer
Copy link
Contributor

@coqbot merge now

@coqbot-app coqbot-app bot merged commit 359a873 into coq:master Jul 5, 2024
7 checks passed
Copy link
Contributor

coqbot-app bot commented Jul 5, 2024

@SkySkimmer: Please take care of the following overlays:

  • 19313-ppedrot-ltac1-split-some-plugins.sh

@ppedrot ppedrot deleted the ltac1-split-some-plugins branch July 5, 2024 12:33
ppedrot added a commit to mattam82/Coq-Equations that referenced this pull request Jul 5, 2024
LasseBlaauwbroek added a commit to coq-tactician/coq-tactician that referenced this pull request Jul 5, 2024
ejgallego pushed a commit to ppedrot/coq-lsp that referenced this pull request Jul 7, 2024
ppedrot added a commit to ejgallego/coq-lsp that referenced this pull request Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: cleanup Code removal, deprecation, refactorings, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants